Do not expand non expnadable volumes #131907
Conversation
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
d2253eb to
eaeaa4f
Compare
eaeaa4f to
23005b1
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gnufied The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| if ne.pvcAlreadyUpdated && storage.ContainsAccessMode(ne.pvc.Spec.AccessModes, v1.ReadWriteMany) { | ||
| // if the volume is already expanded, but volume is of type RWX and | ||
| // pvc doesn't have annotation indicating that node expansion is not required | ||
| // then we should allow node expansion to proceed, even if the volume is already expanded. |
There was a problem hiding this comment.
Will there be any race between multiple node expansion?
There was a problem hiding this comment.
I do not see an easy way this could race with multiple node expansions, even if one node expansion was required and another one wasn't, since we don't start processing 2nd request until previous one finishes.
Did you had a scenario in mind?
There was a problem hiding this comment.
"since we don't start processing 2nd request until previous one finishes" <-- this is what I want to confirm, LGTM.
23005b1 to
96b5ae7
Compare
|
/retest |
| @@ -25,6 +25,10 @@ import ( | ||
| "k8s.io/mount-utils" | ||
| ) | ||
|
|
||
| var ( | ||
| NodeExpansionNotRequired = "volume.kubernetes.io/node-expansion-not-required" |
There was a problem hiding this comment.
Who is going to set the annotation and when?
There was a problem hiding this comment.
|
/remove-sig instrumentation |
|
/lgtm |
|
LGTM label has been added. Git tree hash: eeba590d718d990866316b9de2a4dd0a9ae17817
|
|
/kind bug |
Helps in fixing issues like - #131419
This will be used with kubernetes-csi/external-resizer#496