Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

future-proof csi test mocks #131830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2025
Merged

future-proof csi test mocks #131830

merged 1 commit into from
May 19, 2025
+3 −13

Conversation

dims
Copy link
Member

@dims dims commented May 18, 2025

/kind cleanup

Fix for test compile failure when we switch to using v1.11.0 of github.com/container-storage-interface/spec. You can see the error in:
https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/ci-kubernetes-e2e-kind-dependencies/1923800045233115136

No, we don't want to switch to that version right now, but we should fix our code so it works now as well as when we do move to that version.

to recreate, do the following:

hack/pin-dependency.sh github.com/container-storage-interface/spec v1.11.0
hack/update-vendor.sh

and then compile the e2e.test:

❯ make WHAT=test/e2e/e2e.test
+++ [0517 20:38:42] Building go targets for darwin/arm64
    k8s.io/kubernetes/test/e2e/e2e.test (test)
# k8s.io/kubernetes/test/e2e/storage/drivers/csi-test/mock/service
test/e2e/storage/drivers/csi-test/mock/service/service.go:160:9: cannot use s (variable of type *service) as Service value in return statement: *service does not implement Service (missing method mustEmbedUnimplementedControllerServer)
# k8s.io/kubernetes/test/e2e/storage/drivers/csi-test/driver
test/e2e/storage/drivers/csi-test/driver/mock.go:41:17: cannot use servers.Controller (variable of type *MockControllerServer) as csi.ControllerServer value in struct literal: *MockControllerServer does not implement csi.ControllerServer (missing method mustEmbedUnimplementedControllerServer)
test/e2e/storage/drivers/csi-test/driver/mock.go:42:17: cannot use servers.Node (variable of type *MockNodeServer) as csi.NodeServer value in struct literal: *MockNodeServer does not implement csi.NodeServer (missing method mustEmbedUnimplementedNodeServer)
test/e2e/storage/drivers/csi-test/driver/mock.go:43:17: cannot use servers.Identity (variable of type *MockIdentityServer) as csi.IdentityServer value in struct literal: *MockIdentityServer does not implement csi.IdentityServer (missing method mustEmbedUnimplementedIdentityServer)
!!! [0517 20:39:59] Call tree:
!!! [0517 20:39:59]  1: /Users/davanum/go/src/k8s.io/kubernetes/hack/lib/golang.sh:997 kube::golang::build_binaries_for_platform(...)
!!! [0517 20:39:59]  2: hack/make-rules/build.sh:28 kube::golang::build_binaries(...)
!!! [0517 20:39:59] Call tree:
!!! [0517 20:39:59]  1: hack/make-rules/build.sh:28 kube::golang::build_binaries(...)
make: *** [all] Error 1

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@dims
future-proof csi test mocks
8f49fb5 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 18, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 18, 2025
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2025
@dims
Copy link
Member Author

dims commented May 18, 2025

/assign @xing-yang @liggitt

@dims
Copy link
Member Author

dims commented May 18, 2025

xref: #131839

@dims
Copy link
Member Author

dims commented May 19, 2025

/area code-organization
/area dependency

@k8s-ci-robot k8s-ci-robot added area/code-organization Issues or PRs related to kubernetes code organization area/dependency Issues or PRs related to dependency changes labels May 19, 2025
@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 19, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 18411df262fdaff958fac2fc8a0b6b65575e003b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims
Copy link
Member Author

dims commented May 19, 2025

/retest

@mattcary
Copy link
Contributor

/lgtm

@dims
Copy link
Member Author

dims commented May 19, 2025

/skip

@dims
Copy link
Member Author

dims commented May 19, 2025

/retest

@k8s-ci-robot k8s-ci-robot merged commit f2502b3 into kubernetes:master May 19, 2025
17 of 18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcary mattcary Awaiting requested review from mattcary

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@liggitt liggitt

@xing-yang xing-yang

@mattcary mattcary

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-organization Issues or PRs related to kubernetes code organization area/dependency Issues or PRs related to dependency changes area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
5 participants
@dims @k8s-ci-robot @xing-yang @mattcary @liggitt
Morty Proxy This is a proxified and sanitized view of the page, visit original site.