Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Promote kuberc to beta #131818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 26, 2025
Merged

Promote kuberc to beta #131818

merged 7 commits into from
May 26, 2025

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented May 16, 2025 •
edited
Loading

What type of PR is this?

/kind api-change
/kind feature

What this PR does / why we need it:

This PR promotes kuberc to beta which means that it is enabled by default and can be disabled via:

  • Turning off the feature gate -- KUBECTL_KUBERC=false (when it is promoted to GA, this flag will disappear) or
  • Turning off the functionality -- KUBERC=off

Special notes for your reviewer:

From #131619 (review), which called out the required elements to beta promotion:

  1. Promote kuberc types to beta.

Done in kuberc: add v1beta1 types commit.

  1. With (1) above you'll be able to test the config loading mechanism to ensure that you can load alpha and beta appropriately. At minimum I'd expect:
  • load just alpha
  • load just beta
  • load beta when both alpha and beta is specified
  • load beta when both alpha, beta and alpha2 (non-existing) is specified
  • load alpha1 when both alpha1 and alpha2 (non-existing) is specified
  • error when non-existing (alpha2) version is specified

Done in kuberc: pick the latest known version when decoding + tests commit.

  1. sample e2e

Handles separately in #131757, but also update to beta in Promote kuberc to beta commit.

  1. warning based on this comment which will trigger ONLY when a user previously used the built-in kuberc file and on subsequent iterations it's gone. (Iow. when reading $HOME/.kube/kuberc file for the first time, create a $HOME/.kube/kuberc.inuse (or similar) and check its existence on followup calls. If the file exists but there's no kuberc - warn the user that we failed reading kuberc)

Based on the discussion in kubernetes/enhancements#5300 (comment) and slack discussion with @mpuckett159 we've decided to drop this requirement.

  1. the remaining tests as mentioned in the KEP:
  • config API fuzzy tests
  • input validation and correctness

Fuzzy tests added on kuberc: introduce fuzzing for kuberc types commit. Further validation and correctness will be done in a followup.

/assign @ardaguclu @mpuckett159
from sig-cli pov
/assign @liggitt
for api review

Does this PR introduce a user-facing change?

kubectl: graduated `kuberc` support to beta. A `kuberc` configuration file provides a mechanism for customizing kubectl behavior (separate from kubeconfig, which configured cluster access across different clients).

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-cli/3104-introduce-kuberc

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 16, 2025
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels May 16, 2025
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/code-generation area/kubectl area/test sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 16, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG CLI May 16, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 16, 2025
@soltysh
Copy link
Contributor Author

soltysh commented May 16, 2025

/triage accepted
/priority important-longterm
/label api-review

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. api-review Categorizes an issue or PR as actively needing an API review. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 16, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label May 16, 2025
This was referenced May 15, 2025
Open
Closed
soltysh added 3 commits May 23, 2025 10:56
@soltysh
kuberc: introduce fuzzing for kuberc types
c29acca 
Signed-off-by: Maciej Szulik <soltysh@gmail.com>
@soltysh
kuberc: add API violation exceptions
b8e6de0 
Signed-off-by: Maciej Szulik <soltysh@gmail.com>
@soltysh
kuberc: make update and update-vendor
76f9527 
Signed-off-by: Maciej Szulik <soltysh@gmail.com>
@liggitt
Copy link
Member

liggitt commented May 24, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 52ff86287297a1f176e1153bb958faab61c94b7c

@liggitt liggitt moved this from Changes requested to API review completed, 1.34 in API Reviews May 24, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2025
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

7 similar comments
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@soltysh
Copy link
Contributor Author

soltysh commented May 25, 2025

Flake #129280
/test pull-kubernetes-e2e-kind

@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@soltysh
Copy link
Contributor Author

soltysh commented May 25, 2025

/hold
the failure is blocking the queue, so not worth re-trying

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2025
@soltysh
Copy link
Contributor Author

soltysh commented May 26, 2025

/hold cancel
with kubernetes/test-infra#34851 in, we're seeing green jobs
/test pull-kubernetes-e2e-kind

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2025
@k8s-ci-robot k8s-ci-robot merged commit fe5b989 into kubernetes:master May 26, 2025
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone May 26, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in SIG CLI May 26, 2025
@soltysh soltysh deleted the kuberc_beta branch May 26, 2025 16:50
@lmktfy
Copy link

lmktfy commented May 26, 2025

Changelog suggestion

-kubectl: mechanism for customizing kubectl behavior using preferences from a `kuberc` file (separate from kubeconfig) graduates to beta
+kubectl: graduated `kuberc` support to beta. A `kuberc` configuration file provides a mechanism for customizing kubectl behavior (separate from kubeconfig, which configured cluster access across different clients).

@soltysh
Copy link
Contributor Author

soltysh commented May 27, 2025

Changelog suggestion

Thanks Tim - updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@ardaguclu ardaguclu ardaguclu left review comments

@brianpursley brianpursley Awaiting requested review from brianpursley

@dchen1107 dchen1107 Awaiting requested review from dchen1107

Assignees

@liggitt liggitt

@ardaguclu ardaguclu

@mpuckett159 mpuckett159

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/kubectl area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
API Reviews
Status: API review completed, 1.34
SIG CLI
Status: Done
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
7 participants
@soltysh @lmktfy @ardaguclu @liggitt @k8s-ci-robot @k8s-triage-robot @mpuckett159
Morty Proxy This is a proxified and sanitized view of the page, visit original site.