Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Promote automatic_reloads of authn config metrics to BETA #131798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2025
Merged

Promote automatic_reloads of authn config metrics to BETA #131798

merged 1 commit into from
May 28, 2025

Conversation

aramase
Copy link
Member

@aramase aramase commented May 15, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Promote apiserver_authentication_config_controller_automatic_reloads_total and apiserver_authentication_config_controller_automatic_reload_last_timestamp_seconds metrics to BETA. The feature has been BETA since 1.32 and is planned for GA in 1.34.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Promote `apiserver_authentication_config_controller_automatic_reloads_total` and `apiserver_authentication_config_controller_automatic_reload_last_timestamp_seconds` metrics to BETA.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-auth/3331-structured-authentication-configuration

/triage accepted
/sig auth
/priority important-soon

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. triage/accepted Indicates an issue or PR is ready to be actively worked on. sig/auth Categorizes an issue or PR as relevant to SIG Auth. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 15, 2025
@aramase
Copy link
Member Author

aramase commented May 15, 2025

/assign enj liggitt

@aramase aramase moved this to In Review in SIG Auth May 15, 2025
@k8s-ci-robot k8s-ci-robot added area/apiserver area/stable-metrics Issues or PRs involving stable metrics sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. labels May 15, 2025
@k8s-triage-robot
Copy link

This PR may require stable metrics review.

Stable metrics are guaranteed to not change. Please review the documentation for the requirements and lifecycle of stable metrics and ensure that your metrics meet these guidelines.

@liggitt
Copy link
Member

liggitt commented May 21, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6478147e9a6f1b4f8b8a33389f751365755e3c83

@aramase
Copy link
Member Author

aramase commented May 21, 2025

/assign @rexagod

@aramase aramase mentioned this pull request May 21, 2025
Open
51 tasks
@rexagod
Copy link
Member

rexagod commented May 26, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2025
@k8s-triage-robot
Copy link

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

  • The PR does have any do-not-merge/* labels
  • The PR does not have the needs-ok-to-test label
  • The PR is mergeable (does not have a needs-rebase label)
  • The PR is approved (has cncf-cla: yes, lgtm, approved labels)
  • The PR is failing tests required for merge

You can:

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 26, 2025
@aramase
Promote automatic_reloads of authn config metrics to BETA
60b5338 
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@aramase aramase force-pushed the aramase/f/authn_metrics_beta branch from d4d62c3 to 60b5338 Compare May 27, 2025 05:06
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2025
@k8s-ci-robot k8s-ci-robot requested review from enj, liggitt and rexagod May 27, 2025 05:06
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 27, 2025
@rexagod
Copy link
Member

rexagod commented May 27, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 425fa41cf35176d92445d6a15c5d55a11c8b830a

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase, liggitt, rexagod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacoxu
Copy link
Member

pacoxu commented May 28, 2025

/test pull-kubernetes-e2e-kind

@k8s-ci-robot k8s-ci-robot merged commit d70229f into kubernetes:master May 28, 2025
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone May 28, 2025
@github-project-automation github-project-automation bot moved this from In Review to Closed / Done in SIG Auth May 28, 2025
@aramase aramase deleted the aramase/f/authn_metrics_beta branch May 28, 2025 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@enj enj Awaiting requested review from enj

@liggitt liggitt Awaiting requested review from liggitt

@rexagod rexagod Awaiting requested review from rexagod

Assignees

@liggitt liggitt

@enj enj

@rexagod rexagod

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/stable-metrics Issues or PRs involving stable metrics cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Status: Closed / Done
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
7 participants
@aramase @k8s-triage-robot @liggitt @k8s-ci-robot @rexagod @pacoxu @enj
Morty Proxy This is a proxified and sanitized view of the page, visit original site.