Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add sig/scheduling label to scheduler_perf and staging repo OWNERS #131763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

Add sig/scheduling label to scheduler_perf and staging repo OWNERS #131763

merged 1 commit into from
May 15, 2025
+6 −0

Conversation

macsko
Copy link
Member

@macsko macsko commented May 14, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Labels are automatically added to PRs that change the files in the directory. In kube-scheduler staging repo and scheduler_perf sig/scheduling label was missing, so this PR adds it there.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 14, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 14, 2025
@k8s-ci-robot k8s-ci-robot requested review from AxeZhan and sttts May 14, 2025 11:35
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2025
@macsko
Copy link
Member Author

macsko commented May 14, 2025

/sig scheduling
/hold
/cc @sanposhiho

@k8s-ci-robot k8s-ci-robot requested a review from sanposhiho May 14, 2025 11:35
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels May 14, 2025
@macsko macsko force-pushed the add_sig_scheduling_label_to_perf_and_staging branch from c5dd5f6 to 5121115 Compare May 14, 2025 11:39
sanposhiho
sanposhiho approved these changes May 14, 2025
View reviewed changes
Copy link
Member

@sanposhiho sanposhiho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgmt
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: macsko, sanposhiho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sanposhiho
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 14, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0971bad7b0f67f64e6a4075cdaa209d26fed5b8f

@macsko
Copy link
Member Author

macsko commented May 15, 2025

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2025
@haosdent
Copy link
Member

Do we need to update

staging/src/k8s.io/kube-scheduler/config/OWNERS
test/integration/scheduler_perf/dra/OWNERS

@k8s-ci-robot k8s-ci-robot merged commit 92f6854 into kubernetes:master May 15, 2025
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone May 15, 2025
@macsko
Copy link
Member Author

macsko commented May 15, 2025

Do we need to update

staging/src/k8s.io/kube-scheduler/config/OWNERS
test/integration/scheduler_perf/dra/OWNERS

Don't need to update when parents are labeled.

@macsko macsko mentioned this pull request May 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanposhiho sanposhiho sanposhiho approved these changes

@AxeZhan AxeZhan Awaiting requested review from AxeZhan

@sttts sttts Awaiting requested review from sttts

Assignees

@sanposhiho sanposhiho

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
4 participants
@macsko @k8s-ci-robot @sanposhiho @haosdent
Morty Proxy This is a proxified and sanitized view of the page, visit original site.