Please note that we're already in Test Freeze for the release-1.33 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.33.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Tue Apr 15 07:34:39 UTC 2025.

/wg structured-logging
/area logging
/kind cleanup
/cc @kubernetes/wg-structured-logging-reviews

@Chulong-Li: GitHub didn't allow me to request PR reviews from the following users: kubernetes/wg-structured-logging-reviews.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

Hi @Chulong-Li. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

/cc @bart0sh

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Chulong-Li
Once this PR has been reviewed and has the lgtm label, please assign thockin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

/ok-to-test

/assign

/triage accepted
/priority important-longterm
/retest

/retest

@Chulong-Li Thank you for this PR! It looks good to me so far. Probably one thing that I'd suggest to look at - remaining context.TODO and context.Background calls:

$ git grep '\(Background()\)\|\(TODO()\)' ./pkg/kubelet/volumemanager/
pkg/kubelet/volumemanager/populator/desired_state_of_world_populator.go:                dswp.kubeClient.CoreV1().PersistentVolumeClaims(namespace).Get(context.TODO(), claimName, metav1.GetOptions{})
pkg/kubelet/volumemanager/populator/desired_state_of_world_populator.go:        pv, err := dswp.kubeClient.CoreV1().PersistentVolumes().Get(context.TODO(), name, metav1.GetOptions{})
pkg/kubelet/volumemanager/reconciler/reconstruct.go:    node, fetchErr := rc.kubeClient.CoreV1().Nodes().Get(context.TODO(), string(rc.nodeName), metav1.GetOptions{})
pkg/kubelet/volumemanager/volume_manager_test.go:                       err = manager.WaitForAttachAndMount(context.Background(), pod)
pkg/kubelet/volumemanager/volume_manager_test.go:       err = manager.WaitForAttachAndMount(context.Background(), pod)
pkg/kubelet/volumemanager/volume_manager_test.go:               err = manager.WaitForAttachAndMount(context.Background(), pod)
pkg/kubelet/volumemanager/volume_manager_test.go:               err = manager.WaitForAttachAndMount(context.Background(), pod)
pkg/kubelet/volumemanager/volume_manager_test.go:               kubeClient.CoreV1().PersistentVolumeClaims(namespace).Get(context.TODO(), claimName, metav1.GetOptions{})
pkg/kubelet/volumemanager/volume_manager_test.go:       kubeClient.CoreV1().PersistentVolumeClaims(namespace).Update(context.TODO(), volumeClaim, metav1.UpdateOptions{})
pkg/kubelet/volumemanager/volume_manager_test.go:                       ctx, cancel := context.WithTimeout(context.Background(), 1*time.Second)
pkg/kubelet/volumemanager/volume_manager_test.go:                       err := manager.WaitForAttachAndMount(context.Background(), pod)

It would be nice to get rid of them or at least of some of them.

Hi @bart0sh, thank you for your feedback! I have revised all instances of context.TODO and context.Background in the relevant code sections. Would like to ensure I didn't make it wrong. Could you please take another look?

/retest

@Chulong-Li

have revised all instances of context.TODO and context.Background in the relevant code sections. Would like to ensure I didn't make it wrong. Could you please take another look?

It looks good. Please, fix CI failure and I'll take another look, thanks!

/retest

@Chulong-Li: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.