Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

chore(kubelet): migrate images to contextual logging #130384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
Loading
from
Open

chore(kubelet): migrate images to contextual logging #130384

wants to merge 1 commit into from

Conversation

zhifei92
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

migrate images to contextual logging

Which issue(s) this PR fixes:

Fixes #
part of #130069

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. labels Feb 24, 2025
@zhifei92
Copy link
Contributor Author

/cc @bart0sh

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Feb 24, 2025
@zhifei92 zhifei92 mentioned this pull request Feb 24, 2025
Open
49 tasks
@bart0sh
Copy link
Contributor

bart0sh commented Feb 24, 2025

@zhifei92 Thank you for your PR. Please update ./hack/logcheck.conf and re-generate golangci config, thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhifei92
Once this PR has been reviewed and has the lgtm label, please assign dchen1107 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhifei92
Copy link
Contributor Author

@zhifei92 Thank you for your PR. Please update ./hack/logcheck.conf and re-generate golangci config, thanks!

Done, thanks.

@bart0sh
Copy link
Contributor

bart0sh commented Feb 24, 2025

/lgtm
/triage accepted
/priority important-longterm

/assign @SergeyKanzhelev @mrunalp
for approval

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Feb 24, 2025
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 24, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 59276eb89b9d0afb2eda845fcdf98544d4fbbb62

@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Feb 24, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 18, 2025
@zhifei92 zhifei92 force-pushed the migrate-kubelet-images-to-contextual-logging branch from e9f0a8c to 9253ff3 Compare March 19, 2025 02:06
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 19, 2025
@zhifei92
Copy link
Contributor Author

/test pull-kubernetes-unit

SergeyKanzhelev
SergeyKanzhelev reviewed Mar 20, 2025
View reviewed changes
pkg/kubelet/kubelet.go
@@ -1643,7 +1643,7 @@ func (kl *Kubelet) initializeModules(ctx context.Context) error {
}

// Start the image manager.
kl.imageManager.Start()
kl.imageManager.Start(ctx)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, is it the right context to pass here? initializeModules will likely have a context of initialization stage. While Start will start the background operation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine; the context for initializeModules comes from (kl *Kubelet) Run

@zhifei92 zhifei92 force-pushed the migrate-kubelet-images-to-contextual-logging branch 2 times, most recently from 68f91ad to c05b6d1 Compare March 21, 2025 03:32
@zhifei92
Copy link
Contributor Author

/retest-required

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 3, 2025
@zhifei92 zhifei92 force-pushed the migrate-kubelet-images-to-contextual-logging branch from c05b6d1 to 7fd5877 Compare May 13, 2025 03:15
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2025
@zhifei92 zhifei92 force-pushed the migrate-kubelet-images-to-contextual-logging branch from 7fd5877 to 0b2388b Compare May 13, 2025 06:24
@k8s-ci-robot
Copy link
Contributor

@zhifei92: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-unit-windows-master 0b2388b link false /test pull-kubernetes-unit-windows-master

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev left review comments

@bart0sh bart0sh Awaiting requested review from bart0sh

@feiskyer feiskyer Awaiting requested review from feiskyer

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@mrunalp mrunalp

@SergeyKanzhelev SergeyKanzhelev

@bart0sh bart0sh

Labels
area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node: code and documentation PRs
Status: Needs Approver
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhifei92 @bart0sh @k8s-ci-robot @SergeyKanzhelev @mrunalp
Morty Proxy This is a proxified and sanitized view of the page, visit original site.