Add evanphx/json-patch/v5 to unwanted dependencies #129988
Conversation
This comes up periodically; bumping to v5 introduces issues with replace operations in JSON patches. k/k relies on non-RFC-compliant operations which v5 no longer allows. Signed-off-by: Stephen Kitt <skitt@redhat.com>
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: skitt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/kind cleanup |
|
Are we going to need a v4 fork at some point? |
|
/cc @liggitt |
| @@ -14,6 +14,7 @@ | ||
| "github.com/bketelsen/crypt": "unused, crypto", | ||
| "github.com/containerd/cgroups": "standardize on single cgroups library from runc, refer #128157", | ||
| "github.com/davecgh/go-spew": "refer to #103942", | ||
| "github.com/evanphx/json-patch/v5": "refer to #91622#issuecomment-637087847", |
There was a problem hiding this comment.
full link to #91622 (comment) ?
and this block is only as long as it is incompatible... if v5 became compatible or allowed options to be compatible with v4, we'd probably update and use it
I'd love to see v5 allow use that remains compatible with v4, even if it requires twiddling with how we invoke it |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This comes up periodically; bumping to v5 introduces issues with replace operations in JSON patches. k/k relies on non-RFC-compliant operations which v5 no longer allows.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: