Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add Stress Tests for VolumeAttributesClass #129918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
Loading
from
Open

Add Stress Tests for VolumeAttributesClass #129918

wants to merge 1 commit into from
+256 −0

Conversation

sunnylovestiramisu
Copy link
Contributor

@sunnylovestiramisu sunnylovestiramisu commented Jan 30, 2025 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Stress test coverage for VolumeAttributesClass, add to pull-kubernetes-e2e-gce-storage-slow after VolumeAttributesClass feature gate is on.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Ran go test -timeout=0 -v ./test/e2e -provider=skeleton -kubeconfig $HOME/.kube/config -ginkgo.v -ginkgo.focus='\[FeatureGate:VolumeAttributesClass\]' -gce-zone=us-central1-b -gce-project {MY_GCP_PROJECT} succeeded locally

Does this PR introduce a user-facing change?

N/A

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/pull/5024

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 30, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 30, 2025
@sunnylovestiramisu sunnylovestiramisu force-pushed the stresstest branch 3 times, most recently from d6ad82a to 5b53ec6 Compare January 31, 2025 16:06
@sunnylovestiramisu sunnylovestiramisu mentioned this pull request Jan 31, 2025
Open
@sunnylovestiramisu sunnylovestiramisu force-pushed the stresstest branch 4 times, most recently from f652658 to fb0c190 Compare March 21, 2025 22:44
@sunnylovestiramisu sunnylovestiramisu changed the title [WIP] Add Stress Tests for VolumeAttributesClass Add Stress Tests for VolumeAttributesClass Mar 21, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2025
@carlory
Copy link
Member

carlory commented Mar 24, 2025

/test pull-kubernetes-e2e-kind

@carlory
Copy link
Member

carlory commented Mar 24, 2025

/release-note-none

@k8s-ci-robot
Copy link
Contributor

@carlory: you can only set the release note label to release-note-none if the release-note block in the PR body text is empty or "none".

In response to this:

/release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@carlory
Copy link
Member

carlory commented Apr 25, 2025 •
edited
Loading

@sunnylovestiramisu It looks good to me. Do we have an existing job in test-infra that runs this?

@carlory
Copy link
Member

carlory commented Apr 25, 2025

Stress test coverage for VolumeAttributesClass, add to pull-kubernetes-e2e-gce-storage-slow

Cool. I find it and the job is successful. Thank you.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cfe1a6d2e8550cb01b27deecc60837a9c70c6e3c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, sunnylovestiramisu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2025
@carlory
Copy link
Member

carlory commented Apr 25, 2025

/hold

the job pull-kubernetes-e2e-gce-storage-slow doesn't run new tests.

 - --test_args=--ginkgo.focus=\[sig-storage\].*\[Slow\] --ginkgo.skip=\[Driver:.gcepd\]|\[Serial\]|\[Disruptive\]|\[Flaky\]|\[Feature:.+\] --minStartupPods=8

https://github.com/kubernetes/test-infra/blob/f52ea67ed62d5403b40957d3fcce41efdc39b882/config/jobs/kubernetes/sig-storage/sig-storage-gce-config.yaml#L48 @sunnylovestiramisu

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2025
@carlory carlory mentioned this pull request Apr 30, 2025
Open
@sunnylovestiramisu
Copy link
Contributor Author

/hold

the job pull-kubernetes-e2e-gce-storage-slow doesn't run new tests.

 - --test_args=--ginkgo.focus=\[sig-storage\].*\[Slow\] --ginkgo.skip=\[Driver:.gcepd\]|\[Serial\]|\[Disruptive\]|\[Flaky\]|\[Feature:.+\] --minStartupPods=8

https://github.com/kubernetes/test-infra/blob/f52ea67ed62d5403b40957d3fcce41efdc39b882/config/jobs/kubernetes/sig-storage/sig-storage-gce-config.yaml#L48 @sunnylovestiramisu

:/ That is weird, let me try the test arguments locally.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@sunnylovestiramisu
Copy link
Contributor Author

sunnylovestiramisu commented May 9, 2025 •
edited
Loading

Is the cluster that is running pull-kubernetes-e2e-gce-storage-slow has FeatureGate:VolumeAttributesClass enabled?

We will need to add --env=KUBE_FEATURE_GATES="VolumeAttributesClass=true" to the file you pointed out?

@sunnylovestiramisu
Copy link
Contributor Author

/test pull-kubernetes-e2e-storage-kind-alpha-beta-features

1 similar comment
@sunnylovestiramisu
Copy link
Contributor Author

/test pull-kubernetes-e2e-storage-kind-alpha-beta-features

@k8s-ci-robot
Copy link
Contributor

@sunnylovestiramisu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-kind 9d9a313 link true /test pull-kubernetes-e2e-kind
pull-kubernetes-e2e-kind-ipv6 9d9a313 link true /test pull-kubernetes-e2e-kind-ipv6

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@carlory
Copy link
Member

carlory commented May 11, 2025 •
edited
Loading

WithFeatureGate will add a [Feature:Beta] and [Feature:OffByDefault] to the test name, so it is skipped by the pull-kubernetes-e2e-gce-storage-slow job.
Once the feature is promoted to GA, the [Feature:Beta] will be removed and we have to add a [Feature:OffByDefault] to the test name, please see #131549 (comment) for details.

So, I'm not sure whether the pull-kubernetes-e2e-gce-storage-slow job is the right place to run the test before the feature is promoted to GA and the sidecar images in k/k are updated. cc @sunnylovestiramisu @xing-yang

Maybe we need to create a new temporary job for this? cc @pohly do we have an existing job for stress tests in sig-testing?

@pohly
Copy link
Contributor

pohly commented May 12, 2025

WithFeatureGate will add a [Feature:Beta] and [Feature:OffByDefault] to the test name, so it is skipped by the pull-kubernetes-e2e-gce-storage-slow job.

Update that job to use --label-filter? You can use Feature: isSubsetOf OffByDefault && !Alpha && !Beta and enabled the beta API, but it is not quite accurate because "OffByDefault" implies "all off-by-default APIs".

do we have an existing job for stress tests in sig-testing?

No, not at the moment. ci-kubernetes-e2e-kind-alpha-beta-features excludes slow tests. I wonder whether it should do that. It's a periodic job, so in contrast to a presubmit it is more acceptable to run slow tests. Having a second ci-kubernetes-e2e-kind-alpha-beta-features-slow doesn't really reduce resource consumption, unless we run it less often.

cc @BenTheElder @aojea

@pohly
Copy link
Contributor

pohly commented May 12, 2025

The bigger issue is that a real stress test could lead to test flakes in tests which run in parallel.

@sunnylovestiramisu sunnylovestiramisu mentioned this pull request May 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlory carlory Awaiting requested review from carlory

@humblec humblec Awaiting requested review from humblec

Assignees

@carlory carlory

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sunnylovestiramisu @k8s-ci-robot @carlory @pohly
Morty Proxy This is a proxified and sanitized view of the page, visit original site.