Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Remove general available feature-gate PodDisruptionConditions #129501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2025
Merged

Remove general available feature-gate PodDisruptionConditions #129501

merged 1 commit into from
Jun 12, 2025
+0 −27

Conversation

carlory
Copy link
Member

@carlory carlory commented Jan 7, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The gated code was removed.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Removed generally available feature-gate `PodDisruptionConditions`.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 7, 2025
@carlory carlory mentioned this pull request Jan 7, 2025
Open
@carlory
Copy link
Member Author

carlory commented Jan 7, 2025

/sig apps

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 7, 2025
@sftim
Copy link
Contributor

sftim commented Jan 9, 2025

Changelog suggestion

-Removed general available feature-gate `PodDisruptionConditions`.
+Removed generally available feature-gate `PodDisruptionConditions`.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 15, 2025
@carlory carlory force-pushed the PodDisruptionConditions branch from ff0fe6f to ba8a8da Compare March 15, 2025 08:09
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 15, 2025
@carlory carlory force-pushed the PodDisruptionConditions branch from ba8a8da to 0ff1e37 Compare March 24, 2025 06:05
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 24, 2025
@carlory
Copy link
Member Author

carlory commented Mar 25, 2025

/test pull-kubernetes-e2e-kind-alpha-beta-features
/test pull-kubernetes-e2e-kind-ipv6

@carlory
Copy link
Member Author

carlory commented Apr 24, 2025

/cc @mimowo @xing-yang @jsafrane @liggitt

@k8s-ci-robot k8s-ci-robot requested review from jsafrane and mimowo April 24, 2025 02:18
@mimowo
Copy link
Contributor

mimowo commented Apr 24, 2025

/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4c7e9041ed582588b2f68abd8430d6dfa354e082

@carlory
Copy link
Member Author

carlory commented May 13, 2025

/assign @jsafrane
for approval.

@carlory
Copy link
Member Author

carlory commented Jun 12, 2025

/assign @soltysh @kow3ns
for approval

@liggitt
Copy link
Member

liggitt commented Jun 12, 2025

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2025
soltysh
soltysh approved these changes Jun 12, 2025
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@soltysh
Copy link
Contributor

soltysh commented Jun 12, 2025

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 12, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory, liggitt, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 004d55c into kubernetes:master Jun 12, 2025
16 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jun 12, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in SIG Apps Jun 12, 2025
@carlory carlory deleted the PodDisruptionConditions branch June 13, 2025 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@liggitt liggitt Awaiting requested review from liggitt

@xing-yang xing-yang Awaiting requested review from xing-yang

@jsafrane jsafrane Awaiting requested review from jsafrane

@mimowo mimowo Awaiting requested review from mimowo

Assignees

@soltysh soltysh

@jsafrane jsafrane

@mimowo mimowo

@kow3ns kow3ns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Apps
Status: Done
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
8 participants
@carlory @sftim @mimowo @k8s-ci-robot @liggitt @soltysh @jsafrane @kow3ns
Morty Proxy This is a proxified and sanitized view of the page, visit original site.