Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

DRA Prioritized List: quota enforcement #131805

Copy link
Copy link
Closed
@pohly

Description

@pohly
Issue body actions

What would you like to be added?

When the DRAPrioritizedList feature is enabled, users can bypass the ResourceQuota checking because the resource usage calculation hasn't been updated yet to support that feature:

var numDevices int64
switch request.AllocationMode {
case resourceapi.DeviceAllocationModeExactCount:
numDevices = request.Count
case resourceapi.DeviceAllocationModeAll:
// Worst case...
numDevices = resourceapi.AllocationResultsMaxSize
default:
// Could happen after a downgrade. Unknown modes
// don't count towards the quota and users shouldn't
// expect that when downgrading.
}
quantity := result[deviceClassClaim]
quantity.Add(*(resource.NewQuantity(numDevices, resource.DecimalSI)))
result[deviceClassClaim] = quantity

/wg device-management
/sig scheduling
/cc @mortent @johnbelamaric

Why is this needed?

Must be implemented before promoting DRAPrioritizedList to beta.

Metadata

Metadata

Assignees

Labels

kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.needs-triageIndicates an issue or PR lacks a `triage/foo` label and requires one.Indicates an issue or PR lacks a `triage/foo` label and requires one.sig/schedulingCategorizes an issue or PR as relevant to SIG Scheduling.Categorizes an issue or PR as relevant to SIG Scheduling.wg/device-managementCategorizes an issue or PR as relevant to WG Device Management.Categorizes an issue or PR as relevant to WG Device Management.

Type

No type

Projects

Status

🏗 In progress
Show more project fields

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.