Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add lint check to prevent code generators from adding testing deps #131646

Copy link
Copy link
@jpbetz

Description

@jpbetz
Issue body actions

xref: #131616 (comment)

In this case k8s.io/client-go/testing was depend on by generated code.

Adding the code-generator output directories to the list of packages that hack/verify-testing-import.sh checks should be sufficient.

/sig api-machinery

Metadata

Metadata

Assignees

Labels

sig/api-machineryCategorizes an issue or PR as relevant to SIG API Machinery.Categorizes an issue or PR as relevant to SIG API Machinery.sig/testingCategorizes an issue or PR as relevant to SIG Testing.Categorizes an issue or PR as relevant to SIG Testing.triage/acceptedIndicates an issue or PR is ready to be actively worked on.Indicates an issue or PR is ready to be actively worked on.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.