Open
Description
Having played around with the new generics-based sets API a bit, I really dislike sets.List()
.
The List
/UnsortedList
API always seemed a little bit weird to me, in that the "default" behavior (List
) was to sort the output, and you had to explicitly specify if you didn't want that... Now with the generic version, the naming/behavior is even weirder... UnsortedList
is now distinguishing itself from another method that doesn't actually exist, while List
is now a helper function whose name doesn't really indicate how it helps. The names basically only make sense in the context of comparing them to the old API (which will presumably eventually go away).
So maybe:
- rename
x.UnsortedList()
tox.Elements()
- rename
sets.List(x)
tosets.Sort(x)
orsets.SortElements(x)
orsets.SortedElements(x)
?
Metadata
Metadata
Assignees
Labels
Indicates an issue or PR lacks a `triage/foo` label and requires one.Indicates an issue or PR lacks a `triage/foo` label and requires one.Categorizes an issue or PR as relevant to SIG API Machinery.Categorizes an issue or PR as relevant to SIG API Machinery.