Open
Description
What would you like to be added?
This was previously tracked in #34059 (created in 2016, closed in 2020 after several tests were enhanced).
I'm starting to wonder whether the problem is getting worse again because we still don't catch new tests that use this anti-pattern (for example, #107763).
Is it time to start another spring clean which removes occurrences of this anti-pattern? Or perhaps add some mechanism that prevents it in new code?
/sig testing
/area e2e-test-framework
Why is this needed?
I'm getting tired of seeing failures where the only output is
Expected error:
<*errors.errorString | 0xc820412c10>: {
s: "timed out waiting for the condition",
}
timed out waiting for the condition
not to have occurred
This is the result of
Expect(err).NotTo(HaveOccurred())
or more recently
ExpectNoError(err)
An explanation string would help, but even better solutions would be possible (#106575).
Metadata
Metadata
Assignees
Labels
Issues or PRs related to refactoring the kubernetes e2e test frameworkIssues or PRs related to refactoring the kubernetes e2e test frameworkCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.Indicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.Indicates an issue or PR lacks a `triage/foo` label and requires one.Indicates an issue or PR lacks a `triage/foo` label and requires one.Categorizes an issue or PR as relevant to SIG Testing.Categorizes an issue or PR as relevant to SIG Testing.