Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit e795ae8

Browse filesBrowse files
committed
apiextensions: simplify nil-checking logic in dropDisabledFields
Signed-off-by: jaehanbyun <awbrg789@naver.com>
1 parent 04c1d10 commit e795ae8
Copy full SHA for e795ae8

File tree

Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed
Filter options
  • staging/src/k8s.io/apiextensions-apiserver/pkg/registry/customresourcedefinition
Expand file treeCollapse file tree

1 file changed

+2
-2
lines changed

‎staging/src/k8s.io/apiextensions-apiserver/pkg/registry/customresourcedefinition/strategy.go

Copy file name to clipboardExpand all lines: staging/src/k8s.io/apiextensions-apiserver/pkg/registry/customresourcedefinition/strategy.go
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ func CustomResourceDefinitionToSelectableFields(obj *apiextensions.CustomResourc
231231
// dropDisabledFields drops disabled fields that are not used if their associated feature gates
232232
// are not enabled.
233233
func dropDisabledFields(newCRD *apiextensions.CustomResourceDefinition, oldCRD *apiextensions.CustomResourceDefinition) {
234-
if !utilfeature.DefaultFeatureGate.Enabled(apiextensionsfeatures.CRDValidationRatcheting) && (oldCRD == nil || (oldCRD != nil && !specHasOptionalOldSelf(&oldCRD.Spec))) {
234+
if !utilfeature.DefaultFeatureGate.Enabled(apiextensionsfeatures.CRDValidationRatcheting) && (oldCRD == nil || !specHasOptionalOldSelf(&oldCRD.Spec)) {
235235
if newCRD.Spec.Validation != nil {
236236
dropOptionalOldSelfField(newCRD.Spec.Validation.OpenAPIV3Schema)
237237
}
@@ -242,7 +242,7 @@ func dropDisabledFields(newCRD *apiextensions.CustomResourceDefinition, oldCRD *
242242
}
243243
}
244244
}
245-
if !utilfeature.DefaultFeatureGate.Enabled(apiextensionsfeatures.CustomResourceFieldSelectors) && (oldCRD == nil || (oldCRD != nil && !specHasSelectableFields(&oldCRD.Spec))) {
245+
if !utilfeature.DefaultFeatureGate.Enabled(apiextensionsfeatures.CustomResourceFieldSelectors) && (oldCRD == nil || !specHasSelectableFields(&oldCRD.Spec)) {
246246
dropSelectableFields(&newCRD.Spec)
247247
}
248248
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.