Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 6f3b982

Browse filesBrowse files
committed
add etcd-override health checks
1 parent 6bb6944 commit 6f3b982
Copy full SHA for 6f3b982

File tree

Expand file treeCollapse file tree

2 files changed

+68
-8
lines changed
Filter options
  • staging/src/k8s.io/apiserver/pkg
Expand file treeCollapse file tree

2 files changed

+68
-8
lines changed

‎staging/src/k8s.io/apiserver/pkg/server/options/etcd.go

Copy file name to clipboardExpand all lines: staging/src/k8s.io/apiserver/pkg/server/options/etcd.go
+33-8Lines changed: 33 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -359,14 +359,6 @@ func addHealthChecksWithoutLivez(c *server.Config, healthChecks ...healthz.Healt
359359
}
360360

361361
func (s *EtcdOptions) addEtcdHealthEndpoint(c *server.Config) error {
362-
if s.EtcdServersOverrides != nil {
363-
for _, override := range s.EtcdServersOverrides {
364-
tokens := strings.Split(override, "#")
365-
servers := strings.Split(tokens[1], ";")
366-
s.StorageConfig.Transport.ServerList = append(s.StorageConfig.Transport.ServerList, servers...)
367-
}
368-
}
369-
370362
healthCheck, err := storagefactory.CreateHealthCheck(s.StorageConfig, c.DrainedNotify())
371363
if err != nil {
372364
return err
@@ -383,6 +375,39 @@ func (s *EtcdOptions) addEtcdHealthEndpoint(c *server.Config) error {
383375
return readyCheck()
384376
}))
385377

378+
if s.EtcdServersOverrides != nil {
379+
if err := s.addOverrideEtcdHealthEndpoint(c); err != nil {
380+
return err
381+
}
382+
}
383+
384+
return nil
385+
}
386+
387+
func (s *EtcdOptions) addOverrideEtcdHealthEndpoint(c *server.Config) error {
388+
sc := s.StorageConfig.DeepCopy()
389+
for _, override := range s.EtcdServersOverrides {
390+
tokens := strings.Split(override, "#")
391+
servers := strings.Split(tokens[1], ";")
392+
s.StorageConfig.Transport.ServerList = append(sc.Transport.ServerList, servers...)
393+
}
394+
395+
healthCheck, err := storagefactory.CreateHealthCheck(*sc, c.DrainedNotify())
396+
if err != nil {
397+
return err
398+
}
399+
c.AddHealthChecks(healthz.NamedCheck("etcd-override", func(r *http.Request) error {
400+
return healthCheck()
401+
}))
402+
403+
readyCheck, err := storagefactory.CreateReadyCheck(*sc, c.DrainedNotify())
404+
if err != nil {
405+
return err
406+
}
407+
c.AddReadyzChecks(healthz.NamedCheck("etcd-override-readiness", func(r *http.Request) error {
408+
return readyCheck()
409+
}))
410+
386411
return nil
387412
}
388413

‎staging/src/k8s.io/apiserver/pkg/storage/storagebackend/config.go

Copy file name to clipboardExpand all lines: staging/src/k8s.io/apiserver/pkg/storage/storagebackend/config.go
+35Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,3 +125,38 @@ func NewDefaultConfig(prefix string, codec runtime.Codec) *Config {
125125
Transport: TransportConfig{TracerProvider: noopoteltrace.NewTracerProvider()},
126126
}
127127
}
128+
129+
// DeepCopy returns a deep copy of the Config.
130+
func (c *Config) DeepCopy() *Config {
131+
if c == nil {
132+
return nil
133+
}
134+
// Deep copy the transport config
135+
transport := c.Transport
136+
transportCopy := TransportConfig{
137+
ServerList: make([]string, len(transport.ServerList)),
138+
KeyFile: transport.KeyFile,
139+
CertFile: transport.CertFile,
140+
TrustedCAFile: transport.TrustedCAFile,
141+
EgressLookup: transport.EgressLookup,
142+
TracerProvider: transport.TracerProvider,
143+
}
144+
copy(transportCopy.ServerList, transport.ServerList)
145+
146+
return &Config{
147+
Type: c.Type,
148+
Prefix: c.Prefix,
149+
Transport: transportCopy,
150+
Codec: c.Codec,
151+
EncodeVersioner: c.EncodeVersioner,
152+
Transformer: c.Transformer,
153+
CompactionInterval: c.CompactionInterval,
154+
CountMetricPollPeriod: c.CountMetricPollPeriod,
155+
DBMetricPollInterval: c.DBMetricPollInterval,
156+
EventsHistoryWindow: c.EventsHistoryWindow,
157+
HealthcheckTimeout: c.HealthcheckTimeout,
158+
ReadycheckTimeout: c.ReadycheckTimeout,
159+
LeaseManagerConfig: c.LeaseManagerConfig,
160+
StorageObjectCountTracker: c.StorageObjectCountTracker,
161+
}
162+
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.