Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Label KubeVirt VMs based on cluster id and project id #1981

Merged
kubermatic-bot merged 3 commits intokubermatic:mainkubermatic/machine-controller:mainfrom
moadqassem:read-cluster-and-project-name-from-argsmoadqassem/machine-controller:read-cluster-and-project-name-from-argsCopy head branch name to clipboard
Dec 13, 2025
Merged

Label KubeVirt VMs based on cluster id and project id #1981
kubermatic-bot merged 3 commits intokubermatic:mainkubermatic/machine-controller:mainfrom
moadqassem:read-cluster-and-project-name-from-argsmoadqassem/machine-controller:read-cluster-and-project-name-from-argsCopy head branch name to clipboard

Conversation

@moadqassem
Copy link
Member

What this PR does / why we need it:
This PR add labels to KubeV VMs based on the project and cluster id. These IDs can be read from from the env vars of machine controller.
Which issue(s) this PR fixes:

Fixes #

What type of PR is this?
/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Support project and cluster id for KubeV VMs 

Documentation:

None

Signed-off-by: moadqassem <moad.qassem@gmail.com>

Signed-off-by: moadqassem <moad.qassem@gmail.com>
Signed-off-by: moadqassem <moad.qassem@gmail.com>

Signed-off-by: moadqassem <moad.qassem@gmail.com>
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 12, 2025
Signed-off-by: moadqassem <moad.qassem@gmail.com>

Signed-off-by: moadqassem <moad.qassem@gmail.com>
@kubermatic-bot kubermatic-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 12, 2025
@moadqassem moadqassem requested review from archups and soer3n December 12, 2025 20:03
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2025
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: d617951965acaebf3472ef22334702cfaa69639a

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2025
@kubermatic-bot kubermatic-bot merged commit 41e351d into kubermatic:main Dec 13, 2025
12 checks passed
@moadqassem moadqassem deleted the read-cluster-and-project-name-from-args branch December 14, 2025 10:30
@mohamed-rafraf
Copy link
Member

/cherry-pick release/v1.64

@kubermatic-bot
Copy link
Contributor

@mohamed-rafraf: new pull request created: #1982

Details

In response to this:

/cherry-pick release/v1.64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.