add support for rhel 9 for Azure provider#1963
add support for rhel 9 for Azure provider#1963kubermatic-bot merged 1 commit intokubermatic:mainkubermatic/machine-controller:mainfrom rajaSahil:add-support-rhel-9-azurerajaSahil/machine-controller:add-support-rhel-9-azureCopy head branch name to clipboard
Conversation
Signed-off-by: rajaSahil <sahilraja242@gmail.com>
|
/assign @kron4eg |
| @@ -149,8 +149,8 @@ var imageReferences = map[providerconfig.OperatingSystem]compute.ImageReference{ | ||
| providerconfig.OperatingSystemRHEL: { | ||
| Publisher: to.StringPtr("RedHat"), | ||
| Offer: to.StringPtr("rhel-byos"), |
There was a problem hiding this comment.
what if we try to use official azure RHEL images?
There was a problem hiding this comment.
To use a different image, they need to provide the image ID, that’s the current behaviour we support as well.
|
/retest |
|
looks like it doesn't work 🤷 |
|
This will not work until the OSM PR kubermatic/operating-system-manager#511 is merged. |
|
/retest |
|
/lgtm |
|
LGTM label has been added. DetailsGit tree hash: 5a7b1e77fafef82433978d9c138a591f65125c11 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Add support for rhel 9 for Azure provider.
Which issue(s) this PR fixes:
Fixes #1660
What type of PR is this?
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: