Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat(nutanix): use CachedClient, chore(nutanix): more error log information#1952

Merged
kubermatic-bot merged 2 commits intokubermatic:mainkubermatic/machine-controller:mainfrom
adberger:mainCopy head branch name to clipboard
Aug 4, 2025
Merged

feat(nutanix): use CachedClient, chore(nutanix): more error log information#1952
kubermatic-bot merged 2 commits intokubermatic:mainkubermatic/machine-controller:mainfrom
adberger:mainCopy head branch name to clipboard

Conversation

@adberger
Copy link
Contributor

@adberger adberger commented Aug 4, 2025 •
edited by kron4eg
Loading

What this PR does / why we need it:

  • Add ErrorDetail & ProgressMessage to non-successful Nutanix API calls
  • Switch to CachedClient with session_auth to reduce authentication requests to the Nutanix API

What type of PR is this?

/kind feature
/kind chore

feat(nutanix): use CachedClient
chore(nutanix): more error log information

NONE

chore: Add more logging information for nutanix provider
a9949b7 
Signed-off-by: Adrian Berger <adrian.berger@bedag.ch>
@kubermatic-bot kubermatic-bot added kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/chore Updating grunt tasks etc; no production code changes. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 4, 2025
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Aug 4, 2025

Hi @adberger. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). and removed do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. labels Aug 4, 2025
@kron4eg
Copy link
Member

kron4eg commented Aug 4, 2025

/release-note-edit

feat(nutanix): use CachedClient
chore(nutanix): more error log information

@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Aug 4, 2025

@kron4eg: /release-note-edit must be used with a single release note block.

Details

In response to this:

/release-note-edit

feat(nutanix): use CachedClient
chore(nutanix): more error log information

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kron4eg
Copy link
Member

kron4eg commented Aug 4, 2025

/release-note-edit

feat(nutanix): use CachedClient

@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Aug 4, 2025

@kron4eg: /release-note-edit must be used with a single release note block.

Details

In response to this:

/release-note-edit

feat(nutanix): use CachedClient

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 4, 2025
@kron4eg
Copy link
Member

kron4eg commented Aug 4, 2025

/test all

kron4eg
kron4eg requested changes Aug 4, 2025
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good, just some minor nit

pkg/cloudprovider/provider/nutanix/client.go Show resolved Hide resolved
@adberger
Copy link
Contributor Author

adberger commented Aug 4, 2025

/retest-required

@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Aug 4, 2025

@adberger: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kron4eg
kron4eg reviewed Aug 4, 2025
View reviewed changes
pkg/cloudprovider/provider/nutanix/client.go Outdated Show resolved Hide resolved
@kron4eg
Copy link
Member

kron4eg commented Aug 4, 2025

/test pull-machine-controller-lint

feat: Use clientCache for nutanix provider and activate sessionAuth
b589211 
Signed-off-by: Adrian Berger <adrian.berger@bedag.ch>
@kron4eg
Copy link
Member

kron4eg commented Aug 4, 2025

/retest

@kron4eg
Copy link
Member

kron4eg commented Aug 4, 2025

/test all

@kron4eg
Copy link
Member

kron4eg commented Aug 4, 2025

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2025
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Aug 4, 2025

LGTM label has been added.

DetailsGit tree hash: 797687440dd21a6f8a773aaa1649982c90cfffdb

@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Aug 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2025
@kubermatic-bot kubermatic-bot merged commit 0d86633 into kubermatic:main Aug 4, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kron4eg kron4eg kron4eg requested changes

Assignees

@kron4eg kron4eg

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adberger @kubermatic-bot @kron4eg
Morty Proxy This is a proxified and sanitized view of the page, visit original site.