Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat(openstack): add support for defining multiple networks#1950

Merged
kubermatic-bot merged 6 commits intokubermatic:mainkubermatic/machine-controller:mainfrom
syphernl:feat/openstack_multiple_networkssyphernl/kubermatic-machine-controller:feat/openstack_multiple_networksCopy head branch name to clipboard
Jul 29, 2025
Merged

feat(openstack): add support for defining multiple networks#1950
kubermatic-bot merged 6 commits intokubermatic:mainkubermatic/machine-controller:mainfrom
syphernl:feat/openstack_multiple_networkssyphernl/kubermatic-machine-controller:feat/openstack_multiple_networksCopy head branch name to clipboard

Conversation

@syphernl
Copy link
Contributor

@syphernl syphernl commented Jul 21, 2025 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #263

What type of PR is this?

/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

* Added support for connecting Openstack instance to multiple networks

Documentation:

https://github.com/kubermatic/docs/pull/1922

@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/tbd Denotes a PR that needs documentation (change) that will be done later. kind/feature Categorizes issue or PR as related to a new feature. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 21, 2025
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Jul 21, 2025

Hi @syphernl. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 21, 2025
@syphernl
feat(openstack): add support for defining multiple networks
4f131f5 
Signed-off-by: Frank Klaassen <639906+syphernl@users.noreply.github.com>
@syphernl syphernl force-pushed the feat/openstack_multiple_networks branch from da47b7b to 4f131f5 Compare July 22, 2025 06:52
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. and removed dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. labels Jul 22, 2025
syphernl added 2 commits July 22, 2025 09:04
@syphernl
fix tests
1dd3ccc 
Signed-off-by: Frank Klaassen <639906+syphernl@users.noreply.github.com>
@syphernl
fixes
3e916ca 
Signed-off-by: Frank Klaassen <639906+syphernl@users.noreply.github.com>
@syphernl syphernl mentioned this pull request Jul 22, 2025
Merged
@kubermatic-bot kubermatic-bot added docs/provided Denotes a PR that has a valid documentation reference. and removed docs/tbd Denotes a PR that needs documentation (change) that will be done later. labels Jul 22, 2025
@syphernl
Copy link
Contributor Author

syphernl commented Jul 22, 2025

I have tested the functionality of this with the following scenarios:

  • ✅ Current option: single network with a string
  • ✅ Current option: single network with a string and floating IP
  • ✅ New option: using networks with a list of networks
  • ✅ New option: using networks with a list of networks and a floating IP

In all of the above situations the machine is created/configured as expected.
The old/current option (network with name of the network) still works so this is fully backwards compatible as mentioned in #263 (comment).

@syphernl syphernl marked this pull request as ready for review July 22, 2025 09:25
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 22, 2025
@syphernl
Copy link
Contributor Author

syphernl commented Jul 22, 2025

This is ready for tests / review.

@mohamed-rafraf mohamed-rafraf added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 23, 2025
@syphernl
fix TestMigratingMachine
04a1a47 
Signed-off-by: Frank Klaassen <639906+syphernl@users.noreply.github.com>
@kubermatic-bot kubermatic-bot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 24, 2025
@syphernl
Copy link
Contributor Author

syphernl commented Jul 24, 2025

/retest-required

@kron4eg
Copy link
Member

kron4eg commented Jul 28, 2025

/cc

@kubermatic-bot kubermatic-bot requested a review from kron4eg July 28, 2025 07:59
kron4eg
kron4eg reviewed Jul 28, 2025
View reviewed changes
pkg/cloudprovider/provider/openstack/provider.go Outdated Show resolved Hide resolved
cnvergence
cnvergence reviewed Jul 28, 2025
View reviewed changes
pkg/cloudprovider/provider/openstack/provider.go Outdated Show resolved Hide resolved
syphernl added 2 commits July 29, 2025 08:42
@syphernl
handle both network and networks
a599aa7 
Signed-off-by: Frank Klaassen <639906+syphernl@users.noreply.github.com>
@syphernl
Merge branch 'main' into feat/openstack_multiple_networks
1fdea27 
Signed-off-by: Frank <639906+syphernl@users.noreply.github.com>
@syphernl
Copy link
Contributor Author

syphernl commented Jul 29, 2025

I have tested the functionality of this on our OpenStack environment with the following scenarios:

  • ✅ Current option: single network with a string
  • ✅ Current option: single network with a string and floating IP
  • ✅ New option: using networks with a list of networks
  • ✅ New option: using networks with a list of networks and a floating IP
  • ✅ New option: using network and networks at the same time (network becomes primary, networks are secondary networks)

In all of the above scenarios the machine is created/configured as expected with 1 or multiple (floating) IP's.

@kron4eg
Copy link
Member

kron4eg commented Jul 29, 2025

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2025
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Jul 29, 2025

LGTM label has been added.

DetailsGit tree hash: 4e98f7c2042316c544c29cc10854ae979fbcf7cf

@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Jul 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2025
@kron4eg
Copy link
Member

kron4eg commented Jul 29, 2025

@syphernl thank you very much for your contribution!

@kubermatic-bot kubermatic-bot merged commit a941ab2 into kubermatic:main Jul 29, 2025
12 checks passed
@syphernl syphernl deleted the feat/openstack_multiple_networks branch July 29, 2025 09:18
@syphernl
Copy link
Contributor Author

syphernl commented Jul 29, 2025

@kron4eg Thanks for the feedback and review. Is there any specific release cycle when this change will be included?

@kron4eg
Copy link
Member

kron4eg commented Jul 30, 2025

@syphernl no, but we try to pack some changes together in order to have a meaningful release.

@syphernl
Copy link
Contributor Author

syphernl commented Jul 30, 2025

@syphernl no, but we try to pack some changes together in order to have a meaningful release.

Thanks! Really looking forward to seeing this functionality included as it’s something we need for an ongoing project. It will probably also require an update of the version reference in KubeOne.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kron4eg kron4eg kron4eg left review comments

@cnvergence cnvergence cnvergence left review comments

Assignees

@kron4eg kron4eg

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/provided Denotes a PR that has a valid documentation reference. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

how to point two networks for openstack machine?

5 participants

@syphernl @kubermatic-bot @kron4eg @cnvergence @mohamed-rafraf
Morty Proxy This is a proxified and sanitized view of the page, visit original site.