Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add support to provisioning vcloud workers with multiple nics/networks#1941

Merged
kubermatic-bot merged 5 commits intokubermatic:mainkubermatic/machine-controller:mainfrom
4ch3los:feat/vcloud-multi-nic4ch3los/kubermatic-machine-controller:feat/vcloud-multi-nicCopy head branch name to clipboard
Sep 22, 2025
Merged

Add support to provisioning vcloud workers with multiple nics/networks#1941
kubermatic-bot merged 5 commits intokubermatic:mainkubermatic/machine-controller:mainfrom
4ch3los:feat/vcloud-multi-nic4ch3los/kubermatic-machine-controller:feat/vcloud-multi-nicCopy head branch name to clipboard

Conversation

@4ch3los
Copy link
Contributor

@4ch3los 4ch3los commented Jun 25, 2025 •
edited
Loading

What this PR does / why we need it:
This pr adds the ability to create machines in vmware cloud director with multiple nics using different networks. This is especially useful when you want to use a additional nic for storage

Which issue(s) this PR fixes:

What type of PR is this?

/kind feature

Special notes for your reviewer:

This change just adds the nic to the vm, for the configuration there is a osm pr kubermatic/operating-system-manager#471

Does this PR introduce a user-facing change? Then add your Release Note here:

Added the option to provision vmware cloud director nodes with multiple networks/nics

Documentation:

TBD

@4ch3los
Add support to provision vcloud workers with multiple nics/networks
30e70e4 
Signed-off-by: Kai Fink <kai.fink@yahoo.de>
@kubermatic-bot kubermatic-bot added docs/tbd Denotes a PR that needs documentation (change) that will be done later. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 25, 2025
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Jun 25, 2025

Hi @4ch3los. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 25, 2025
@4ch3los 4ch3los mentioned this pull request Jun 25, 2025
Merged
@4ch3los 4ch3los changed the title feat: Add support to provisioning vcloud workers with multiple nics/networks Add support to provisioning vcloud workers with multiple nics/networks Jun 25, 2025
@4ch3los 4ch3los mentioned this pull request Jun 25, 2025
Merged
@kron4eg
Copy link
Member

kron4eg commented Jul 29, 2025

/cc

@kubermatic-bot kubermatic-bot requested a review from kron4eg July 29, 2025 13:18
kron4eg
kron4eg requested changes Jul 29, 2025
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions

pkg/cloudprovider/provider/vmwareclouddirector/provider.go Outdated Show resolved Hide resolved
pkg/cloudprovider/provider/vmwareclouddirector/provider.go Show resolved Hide resolved
@4ch3los
Migrate VMware Cloud Director network settings to support multi-netwo…
ef37634 
…rk configurations

Signed-off-by: Kai Fink <kai.fink@yahoo.de>
@4ch3los
Prepend instead of append, to ensure the same network stays the primary
564a3c0 
Signed-off-by: Kai Fink <kai.fink@yahoo.de>
kron4eg
kron4eg reviewed Sep 18, 2025
View reviewed changes
pkg/admission/util.go Show resolved Hide resolved
@4ch3los
Deduplicate networks to avoid duplicate entries in configurations
1a380d3 
Signed-off-by: Kai Fink <kai.fink@yahoo.de>
@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 18, 2025
kron4eg
kron4eg approved these changes Sep 19, 2025
View reviewed changes
Copy link
Member

@kron4eg kron4eg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

thanks!

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2025
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Sep 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2025
@kubermatic-triage-bot
Copy link

kubermatic-triage-bot commented Sep 19, 2025

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@kubermatic-triage-bot
Copy link

kubermatic-triage-bot commented Sep 19, 2025

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kron4eg
Copy link
Member

kron4eg commented Sep 19, 2025

/lgtm cancel

@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2025
@kron4eg
Copy link
Member

kron4eg commented Sep 19, 2025

@4ch3los please fix the lint warning

@4ch3los
Remove unnecessary newline in error handling block
35bc88b 
Signed-off-by: Kai Fink <kai.fink@yahoo.de>
@kron4eg
Copy link
Member

kron4eg commented Sep 19, 2025

/test pull-machine-controller-lint

@kron4eg
Copy link
Member

kron4eg commented Sep 22, 2025

/ok-to-test

@kubermatic-bot kubermatic-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 22, 2025
@xrstf
Copy link
Contributor

xrstf commented Sep 22, 2025

/override pull-machine-controller-e2e-vmware-cloud-director

@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Sep 22, 2025

@xrstf: Overrode contexts on behalf of xrstf: pull-machine-controller-e2e-vmware-cloud-director

Details

In response to this:

/override pull-machine-controller-e2e-vmware-cloud-director

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2025
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Sep 22, 2025

LGTM label has been added.

DetailsGit tree hash: 6189a030b74cdb85c7f64f85f84a26bc6a37bc28

@kubermatic-bot kubermatic-bot merged commit ff10585 into kubermatic:main Sep 22, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/tbd Denotes a PR that needs documentation (change) that will be done later. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@4ch3los @kubermatic-bot @kron4eg @kubermatic-triage-bot @xrstf
Morty Proxy This is a proxified and sanitized view of the page, visit original site.