Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Update to Go 1.24.2, golangci-lint 2.x#1914

Merged
kubermatic-bot merged 4 commits intokubermatic:mainkubermatic/machine-controller:mainfrom
xrstf:go124xrstf/machine-controller:go124Copy head branch name to clipboard
Apr 4, 2025
Merged

Update to Go 1.24.2, golangci-lint 2.x#1914
kubermatic-bot merged 4 commits intokubermatic:mainkubermatic/machine-controller:mainfrom
xrstf:go124xrstf/machine-controller:go124Copy head branch name to clipboard

Conversation

@xrstf
Copy link
Contributor

@xrstf xrstf commented Apr 3, 2025

What this PR does / why we need it:
Nothing really too special to see. :)

What type of PR is this?
/kind chore

Does this PR introduce a user-facing change? Then add your Release Note here:

Update to Go 1.24.2

Documentation:

NONE

@kubermatic-bot kubermatic-bot added kind/chore Updating grunt tasks etc; no production code changes. release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 3, 2025
@xrstf
Copy link
Contributor Author

xrstf commented Apr 4, 2025

/override pull-machine-controller-e2e-vmware-cloud-director

The VCD environment is not set up correctly to run tests.

@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Apr 4, 2025

@xrstf: Overrode contexts on behalf of xrstf: pull-machine-controller-e2e-vmware-cloud-director

Details

In response to this:

/override pull-machine-controller-e2e-vmware-cloud-director

The VCD environment is not set up correctly to run tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kron4eg
Copy link
Member

kron4eg commented Apr 4, 2025

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2025
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Apr 4, 2025

LGTM label has been added.

DetailsGit tree hash: 78f82bb65bb3a906662dd59de56bbbdfa9712a16

@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Apr 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2025
@xrstf
Copy link
Contributor Author

xrstf commented Apr 4, 2025

/retest

@kubermatic-bot kubermatic-bot merged commit 744bbba into kubermatic:main Apr 4, 2025
18 checks passed
@xrstf xrstf deleted the go124 branch April 4, 2025 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kron4eg kron4eg

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xrstf @kubermatic-bot @kron4eg
Morty Proxy This is a proxified and sanitized view of the page, visit original site.