Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Move APIs and cloud provider types into standalone Go module in ./sdk#1900

Merged
kubermatic-bot merged 12 commits intokubermatic:mainkubermatic/machine-controller:mainfrom
xrstf:mc-sdkxrstf/machine-controller:mc-sdkCopy head branch name to clipboard
Feb 28, 2025
Merged

Move APIs and cloud provider types into standalone Go module in ./sdk#1900
kubermatic-bot merged 12 commits intokubermatic:mainkubermatic/machine-controller:mainfrom
xrstf:mc-sdkxrstf/machine-controller:mc-sdkCopy head branch name to clipboard

Conversation

@xrstf
Copy link
Contributor

@xrstf xrstf commented Feb 28, 2025 •
edited
Loading

What this PR does / why we need it:
To make it easier to use the machine-controller's types and APIs, this PR moves the Kube APIs, cloud provider types, providerconfig and userdata into a new Go module in the sdk directory. Consumers can then simply import k8c.io/machine-controller/sdk and avoid having to also import heavy cloud provider dependencies.

No changes were made to the actual API definitions.

What type of PR is this?
/kind api-change

Does this PR introduce a user-facing change? Then add your Release Note here:

Introduce a new `k8c.io/machine-controller/sdk` Go module that contains the Kube APIs, cloud provider types, providerconfig etc.

Documentation:

NONE

@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Feb 28, 2025
@xrstf
Copy link
Contributor Author

xrstf commented Feb 28, 2025

/test all

@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Feb 28, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. docs/none Denotes a PR that doesn't need documentation (changes). release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 28, 2025
@xrstf xrstf marked this pull request as ready for review February 28, 2025 15:48
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2025
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Feb 28, 2025 •
edited
Loading

@xrstf: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-machine-controller-e2e-vmware-cloud-director c3004f2 link false /test pull-machine-controller-e2e-vmware-cloud-director

Full PR test history

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

xmudrii
xmudrii reviewed Feb 28, 2025
View reviewed changes
sdk/Makefile
Comment on lines +17 to +18
golangci-lint run --verbose --print-resources-usage ./...
golangci-lint run --verbose --print-resources-usage --config ../.golangci.yml ./...
Copy link
Member

@xmudrii xmudrii Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we run golangci-lint two times? Can you leave a comment in the Makefile why do we do this if this is intentional?

xmudrii
xmudrii approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic! :shipit:
/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2025
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Feb 28, 2025

LGTM label has been added.

DetailsGit tree hash: 76c519bdbb56d7320e8539c59219a4e2d9b54219

@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Feb 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2025
@kubermatic-bot kubermatic-bot merged commit 91d2aec into kubermatic:main Feb 28, 2025
21 of 22 checks passed
@xrstf xrstf deleted the mc-sdk branch April 3, 2025 13:12
@soer3n
Copy link
Contributor

soer3n commented Apr 4, 2025

/cherrypick release/v1.61

@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Apr 4, 2025

@soer3n: #1900 failed to apply on top of branch "release/v1.61":

Applying: it compiles
Using index info to reconstruct a base tree...
M	pkg/cloudprovider/provider.go
A	pkg/cloudprovider/provider/external/provider.go
M	pkg/controller/machine/controller.go
M	pkg/providerconfig/types/types.go
M	test/e2e/provisioning/helper.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/provisioning/helper.go
Auto-merging sdk/providerconfig/types.go
Auto-merging pkg/controller/machine/controller.go
Removing pkg/cloudprovider/provider/vultr/types/types.go
Removing pkg/cloudprovider/provider/vsphere/types/types.go
Removing pkg/cloudprovider/provider/openstack/types/types.go
Removing pkg/cloudprovider/provider/opennebula/types/types.go
Removing pkg/cloudprovider/provider/kubevirt/types/types.go
Removing pkg/cloudprovider/provider/hetzner/types/types.go
Removing pkg/cloudprovider/provider/gce/types/types.go
CONFLICT (modify/delete): pkg/cloudprovider/provider/external/provider.go deleted in HEAD and modified in it compiles. Version it compiles of pkg/cloudprovider/provider/external/provider.go left in tree.
Removing pkg/cloudprovider/provider/digitalocean/types/types.go
Removing pkg/cloudprovider/provider/azure/types/types.go
Removing pkg/cloudprovider/provider/aws/types/types.go
Removing pkg/cloudprovider/provider/anexia/types/errors.go
Removing pkg/cloudprovider/provider/alibaba/types/types.go
Auto-merging pkg/cloudprovider/provider.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 it compiles
Details

In response to this:

/cherrypick release/v1.61

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xrstf @kubermatic-bot @soer3n @xmudrii
Morty Proxy This is a proxified and sanitized view of the page, visit original site.