Support External Cloud Provider#1898
Merged
kubermatic-bot merged 1 commit intokubermatic:mainkubermatic/machine-controller:mainfrom Feb 10, 2025
moadqassem:support-external-providermoadqassem/machine-controller:support-external-providerCopy head branch name to clipboard
Merged
Support External Cloud Provider#1898kubermatic-bot merged 1 commit intokubermatic:mainkubermatic/machine-controller:mainfrom moadqassem:support-external-providermoadqassem/machine-controller:support-external-providerCopy head branch name to clipboard
kubermatic-bot merged 1 commit intokubermatic:mainkubermatic/machine-controller:mainfrom
moadqassem:support-external-providermoadqassem/machine-controller:support-external-providerCopy head branch name to clipboard
Conversation
Signed-off-by: moadqassem <moad.qassem@gmail.com> Signed-off-by: moadqassem <moad.qassem@gmail.com>
b88c3fc to
52d1540
Compare
Contributor
|
LGTM label has been added. DetailsGit tree hash: 0c6b009d630c3933b55df54eac98c15e531362c0 |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces a new provider called external, which takes care of the machine deployment lifecycle from a machine controller point of view. Another external service should be responsible for creating and orchestrating that cloud instance and sync these changes back to the machine object(e.g: adding labels, remove finalizers upon deleting etc...)
Which issue(s) this PR fixes:
Fixes #
What type of PR is this?
/kind feature
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: