Please consider the following formatting changes to #14859#365
Closed
alibuild wants to merge 3 commits intoktf:pr14859ktf/AliceO2:pr14859from
alibuild:alibot-cleanup-14859alibuild/AliceO2:alibot-cleanup-14859Copy head branch name to clipboard
Closed
Please consider the following formatting changes to #14859#365alibuild wants to merge 3 commits intoktf:pr14859ktf/AliceO2:pr14859from alibuild:alibot-cleanup-14859alibuild/AliceO2:alibot-cleanup-14859Copy head branch name to clipboard
alibuild wants to merge 3 commits intoktf:pr14859ktf/AliceO2:pr14859from
alibuild:alibot-cleanup-14859alibuild/AliceO2:alibot-cleanup-14859Copy head branch name to clipboard
Conversation
Separate routing of the forwarding to a separate helper. Add test for said helper.
If a message came together with a DomainInfoHeader or a SourceInfoHeader, it would have not been forwarded. If one (header, payload, ...) tuple in a MessageSet was to be copied, all the subsequent ones would have been copied. If one (header, payload, ...) tuple got redirected to more than one destination, all the subsequent ones would have been redirected there.
ceab1b6 to
1fa2c1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your PR AliceO2Group#14859 cannot be merged as is. You should either run
clang-formatyourself and update the pull request, or merge this PR in yours.You can find the AliceO2 coding conventions at https://github.com/AliceO2Group/CodingGuidelines.