This repository was archived by the owner on Mar 22, 2024. It is now read-only.
Added a nullHandler function to deal with blank line input.#5
Open
dekay wants to merge 3 commits intokroimon:masterkroimon/Arduino-SerialCommand:masterfrom
Open
Added a nullHandler function to deal with blank line input.#5dekay wants to merge 3 commits intokroimon:masterkroimon/Arduino-SerialCommand:masterfrom
dekay wants to merge 3 commits intokroimon:masterkroimon/Arduino-SerialCommand:masterfrom
Conversation
Author
|
Added a second commit that adds support for a second line terminator. In my application, I needed to handle lines that terminated in either 0x0a or 0x0d. This probably should have been done in a separate branch from the other change. Sorry about that. I'm a git newb. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change recognizes when the user hits return on a blank line. I needed to handle this case for my project (a blank line is used to wake the device I am emulating, after which it sends an ack() response), but I can see it coming in useful in other applications.