Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix wrong describe syntax for Revisions. #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix wrong describe syntax for Revisions. #111

wants to merge 1 commit into from

Conversation

yanggangtony
Copy link

@yanggangtony yanggangtony commented Dec 1, 2023 •
edited
Loading

Changes

Fix wrong describe syntax for Revisions.

-:broom: Update or clean up current behavior

Fix wrong describe syntax for Revisions.
d68741c 
Signed-off-by: yanggang <gang.yang@daocloud.io>
@knative-prow Knative Prow
Copy link

knative-prow bot commented Dec 1, 2023

@yanggangtony: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

Fix wrong describe syntax for Revisions.

-:broom: Update or clean up current behavior

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow Knative Prow
Copy link

knative-prow bot commented Dec 1, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yanggangtony
Once this PR has been reviewed and has the lgtm label, please assign smoser-ibm for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow Knative Prow
Copy link

knative-prow bot commented Dec 1, 2023

Welcome @yanggangtony! It looks like this is your first PR to knative/specs 🎉

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 1, 2023
@dprotaso
Copy link
Member

dprotaso commented Jan 9, 2024

I'm going to close this out - the section your editing is written a certain way (it spans multiple line breaks)

Your changes break the run-on sentence.

I'm open to reworking the entire section if you prefer to change it.

@dprotaso dprotaso closed this Jan 9, 2024
@yanggangtony yanggangtony deleted the fix-Revisions-desc branch January 9, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@smoser-ibm smoser-ibm Awaiting requested review from smoser-ibm

Assignees

No one assigned

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yanggangtony @dprotaso
Morty Proxy This is a proxified and sanitized view of the page, visit original site.