Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@AndreMiras
Copy link
Member

  • s/codeblock/code-block/
  • fixes code block being nested because of previous literal block ::

See screenshot attached, to the left before the change, to the right after the change:
image

- s/codeblock/code-block/
- fixes code block being nested because of previous literal block `::`
Copy link
Member

@opacam opacam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!!

Note: I see the tox tests failing with coveralls error, but this is solved at #2119, which is not included in here and already merged into develop branch, so we should be fine 👍

@AndreMiras
Copy link
Member Author

Yes indeed I didn't rebase that one. In theory I should, but I'll simply merge instead 😛
Thanks for the review

@AndreMiras AndreMiras merged commit cfabe37 into kivy:develop Apr 6, 2020
@AndreMiras AndreMiras deleted the feature/rst_documentation_fixes branch April 6, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.