🐛 Add -fPIC to CFLAGS for Arch x86_64
#2085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since, at this point, we know that we need to add the mentioned flags at some point, let's be brave and try to add it at Arch level (since we need `-fPIC` for `ArchARMv7_a` it may be also the case for `Archx86_64`) **See also:** - kivy#2073 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is extracted from the tests we made at #2073 (commit message slightly modified, not the content) and it seems that solves the build problems detected in there...unfortunatelly I cannot test any
apkwith this fix, but it solves the build problem...so I recommend to merge it 😉See also:
on_device_unit_test_app#2046 #2073 (comment)