310 add rendering for spdx licenses #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
…g sanitization Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Member
Author
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds rendering support for SPDX license identifiers in the PID component and updates related rendering logic and stories.
- Imported
SPDXTypeand inserted it into the renderer priority list. - Adjusted conditional checks in
RORTypeandPidDataTablefor link rendering and dynamic subcomponent loading. - Added Storybook stories for long and short SPDX license examples.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/stencil-library/src/utils/utils.ts | Imported SPDXType and updated the renderers priority order. |
| packages/stencil-library/src/rendererModules/RORType.tsx | Removed isEmpty() check when rendering external links. |
| packages/stencil-library/src/components/pid-data-table/pid-data-table.tsx | Inverted value.renderDynamically checks for subcomponent loading. |
| packages/stencil-library/src/components/pid-component/pid-component.stories.ts | Added SPDXLong and SPDXShort stories. |
Comments suppressed due to low confidence (4)
packages/stencil-library/src/utils/utils.ts:47
- New renderer for SPDXType is introduced but lacks unit tests to verify correct detection and rendering of SPDX licenses. Consider adding test cases that cover both short and long form identifiers.
key: 'SPDXType',
packages/stencil-library/src/components/pid-component/pid-component.stories.ts:194
- [nitpick] Consider adding brief descriptions for
SPDXLongandSPDXShortstories to explain their use cases in the Storybook documentation.
export const SPDXLong: Story = {
packages/stencil-library/src/rendererModules/RORType.tsx:148
- Removing the
isEmpty()check may lead to empty or undefined link labels (e.g., “Link to ”). Reintroduce a non-empty check or validatelink.typebefore constructing the label.
if (link.type) {
packages/stencil-library/src/components/pid-data-table/pid-data-table.tsx:154
- The condition for rendering foldable subcomponents was inverted to
value.renderDynamically. Verify this change matches the intended behavior for dynamic vs. preview rendering, as it may now render subcomponents in the wrong scenario.
this.loadSubcomponents && !this.hideSubcomponents && value.renderDynamically ? (
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.