created ror component #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maximilian Inckmann <maximilian.inckmann@kit.edu>
Closed
10 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds support for rendering Research Organization Registry (ROR) identifiers by introducing a new RORType renderer, updating the renderer registry, and providing a Storybook example.
- Register
RORTypein the renderer utilities with updated priorities. - Implement
RORTypeinrendererModulesto fetch and display ROR data. - Add a Storybook story for ROR entries and tweak existing story CSS classes.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/stencil-library/src/utils/utils.ts | Imported and registered RORType, bumped other renderer priorities |
| packages/stencil-library/src/utils/GenericIdentifierType.ts | Added @returns tag to init method documentation |
| packages/stencil-library/src/rendererModules/RORType.tsx | New RORType implementation for fetching/displaying ROR data |
| packages/stencil-library/src/components/pid-component/pid-component.stories.ts | Added ROR story and reordered CSS classes in a <p> tag |
Comments suppressed due to low confidence (1)
packages/stencil-library/src/rendererModules/RORType.tsx:99
Stringdoes not have anisEmpty()method; consider checking!link.typeorlink.type.trim().length === 0.
if (link.type && link.type.isEmpty()) {
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #17