read cargo configs with/without .toml extension + make public API clearer#437
Open
chrismooredev wants to merge 5 commits intokillercup:masterkillercup/cargo-edit:masterfrom
Open
read cargo configs with/without .toml extension + make public API clearer#437chrismooredev wants to merge 5 commits intokillercup:masterkillercup/cargo-edit:masterfrom
chrismooredev wants to merge 5 commits intokillercup:masterkillercup/cargo-edit:masterfrom
Conversation
also prevent unnecessary UTF8 compliance assertion for $CARGO_HOME
(registry.rs) broke `registry_url` down into smaller functions (registry.rs) implemented RegistryReq struct, meant to abstract the idea of 'getting a registry' - allows obtaining a registry without attaching a project directory, or traversing the file system (direct URL) (fetch.rs) seperate concerns with get_latest_dependency - caller shouldn't have to get the registry URL - just know the context of the request (upgrade/main.rs) add comments to & reorganize DesiredUpgrades::get_upgraded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal for my series of commits is to consolidate repeated functionality and make this crate easier to use for those using it's public Rust API.
commit ff1e158:
cargo_edit::registry::cargo_homefrom unnecessarily getting $HOME, or checking UTF8 compliance.commit 03f6d74: introduce new structs to drive a new public, programmable API
.cargo/configand.cargo/config.tomlfilesRegistryReqandRegistryIndexstructs, and attaches many of the freestanding functions incargo_edit::registryinto those.RegistryReqnotably allows a new user of the public API to more easily figure out the latest dependency of a crate without supplying a project directory.commit 1c986a6:
RegistryReqandRegistryIndexstructscommit 933ebfe:
I plan to do a major bump once I am done editing the public API, if that is welcomed :)