Fix read-only array error in FractionalBacktest indicator scaling#1359
Open
atharvajoshi01 wants to merge 1 commit intokernc:masterkernc/backtesting.py:masterfrom
atharvajoshi01:fix/read-only-fractional-indicatoratharvajoshi01/backtesting.py:fix/read-only-fractional-indicatorCopy head branch name to clipboard
Open
Fix read-only array error in FractionalBacktest indicator scaling#1359atharvajoshi01 wants to merge 1 commit intokernc:masterkernc/backtesting.py:masterfrom atharvajoshi01:fix/read-only-fractional-indicatoratharvajoshi01/backtesting.py:fix/read-only-fractional-indicatorCopy head branch name to clipboard
atharvajoshi01 wants to merge 1 commit intokernc:masterkernc/backtesting.py:masterfrom
atharvajoshi01:fix/read-only-fractional-indicatoratharvajoshi01/backtesting.py:fix/read-only-fractional-indicatorCopy head branch name to clipboard
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the CI failure in test_FractionalBacktest where indicator /= self._fractional_unit raises ValueError: output array is read-only on newer pandas.
The in-place division fails because the underlying numpy array from pandas is read-only (copy-on-write). Replaced with a non-mutating division that creates a new array and updates the list entry directly.
Ref: #1354