keithrob
diff --git a/‎src/plots/cartesian/layout_attributes.js
Copy file name to clipboardExpand all lines: src/plots/cartesian/layout_attributes.js
+1-1Lines changed: 1 addition & 1 deletion b/‎src/plots/cartesian/layout_attributes.js
Copy file name to clipboardExpand all lines: src/plots/cartesian/layout_attributes.js
+1-1Lines changed: 1 addition & 1 deletion
diff --git a/‎src/plots/plots.js
Copy file name to clipboardExpand all lines: src/plots/plots.js
+63Lines changed: 63 additions & 0 deletions b/‎src/plots/plots.js
Copy file name to clipboardExpand all lines: src/plots/plots.js
+63Lines changed: 63 additions & 0 deletions
diff --git a/‎test/image/baselines/hist_category_value_ascending.png
Copy file name to clipboard
11.1 KB b/‎test/image/baselines/hist_category_value_ascending.png
Copy file name to clipboard
11.1 KB
diff --git a/‎test/image/baselines/scatter_category_value_descending.png
Copy file name to clipboard
13.1 KB b/‎test/image/baselines/scatter_category_value_descending.png
Copy file name to clipboard
13.1 KB
diff --git a/‎test/image/mocks/hist_category_value_ascending.json
Copy file name to clipboard
+19Lines changed: 19 additions & 0 deletions b/‎test/image/mocks/hist_category_value_ascending.json
Copy file name to clipboard
+19Lines changed: 19 additions & 0 deletions
diff --git a/‎test/image/mocks/scatter_category_value_descending.json
Copy file name to clipboard
+26Lines changed: 26 additions & 0 deletions b/‎test/image/mocks/scatter_category_value_descending.json
Copy file name to clipboard
+26Lines changed: 26 additions & 0 deletions
@@ -817,7 +817,7 @@ module.exports = {
     categoryorder: {
         valType: 'enumerated',
         values: [
-            'trace', 'category ascending', 'category descending', 'array'
+            'trace', 'category ascending', 'category descending', 'array', 'value ascending', 'value descending'
             /* , 'value ascending', 'value descending'*/ // value ascending / descending to be implemented later
         ],
         dflt: 'trace',
 
@@ -2843,10 +2843,73 @@ plots.doCalcdata = function(gd, traces) {
 
     doCrossTraceCalc(gd);
 
+    // Sort axis categories per value if specified
+    if(sortAxisCategoriesByValue(axList, gd)) {
+        // If a sort operation was performed, run calc() again
+        for(i = 0; i < fullData.length; i++) calci(i, true);
+        for(i = 0; i < fullData.length; i++) calci(i, false);
+        doCrossTraceCalc(gd);
+    }
+
     Registry.getComponentMethod('fx', 'calc')(gd);
     Registry.getComponentMethod('errorbars', 'calc')(gd);
 };
 
+function sortAxisCategoriesByValue(axList, gd) {
+    var sortByValue = false;
+    for(var i = 0; i < axList.length; i++) {
+        var ax = axList[i];
+        if(ax.type !== 'category') continue;
+
+        // Order by value
+        if(ax.categoryorder === 'value ascending' ||
+            ax.categoryorder === 'value descending') {
+            sortByValue = true;
+            // Store value associated with each category
+            var categoriesValue = [];
+            var j;
+            for(j = 0; j < ax._categories.length; j++) {
+                categoriesValue.push([ax._categories[j], 0]);
+            }
+
+            // Aggregate values across traces
+            for(j = 0; j < ax._traceIndices.length; j++) {
+                var traceIndex = ax._traceIndices[j];
+                var fullData = gd._fullData[traceIndex];
+                if(fullData.visible !== true) continue;
+                var cd = gd.calcdata[traceIndex];
+                var type = fullData.type;
+                for(var k = 0; k < cd.length; k++) {
+                    if(type === 'scatter') {
+                        categoriesValue[cd[k].x][1] += cd[k].y;
+                    } else if(type === 'histogram') {
+                        categoriesValue[cd[k].p][1] += cd[k].s;
+                    }
+                }
+            }
+
+            // Sort by value
+            categoriesValue.sort(function(a, b) {
+                return a[1] - b[1];
+            });
+
+            // Set new category order
+            ax._initialCategories = categoriesValue.map(function(c) {
+                return c[0];
+            });
+
+            // Reverse if descending
+            if(ax.categoryorder === 'value descending') {
+                ax._initialCategories.reverse();
+            }
+
+            // Reinitialize axis
+            ax.clearCalc();
+        }
+    }
+    return sortByValue;
+}
+
 function setupAxisCategories(axList, fullData) {
     for(var i = 0; i < axList.length; i++) {
         var ax = axList[i];
 
@@ -0,0 +1,19 @@
+{
+  "data": [{
+    "x": ["a", "b", "c", "a", "b", "d", "b", "c"],
+    "type": "histogram"
+  },
+  {
+    "x": ["d", "c", "b", "a", "e", "a", "b"],
+    "type": "histogram"
+  }],
+  "layout": {
+    "title": "xaxis.categoryorder: \"value ascending\"",
+    "height": 300,
+    "width": 400,
+    "barmode": "stack",
+    "xaxis": {
+      "categoryorder": "value ascending"
+    }
+  }
+}
@@ -0,0 +1,26 @@
+{
+    "data": [
+        {
+            "x": ["a", "b", "c", "d"],
+            "y": [4, 2, 3, 1],
+            "type": "scatter",
+            "mode": "markers"
+        },
+        {
+            "x": ["a", "b", "c", "d", "c", "c"],
+            "type": "histogram"
+        }
+    ],
+    "layout": {
+        "title": "xaxis.categoryorder: \"value descending\"",
+        "width": 400,
+        "height": 400,
+        "xaxis": {
+            "domain": [
+                0,
+                1
+            ],
+            "categoryorder": "value descending"
+        }
+    }
+}