#243 Adjusted iteration values#244
#243 Adjusted iteration values#244jathavaan merged 1 commit intomainkartAI/doppa:mainfrom bugfix/243-increase-benchmark-iteration-for-point-in-polygon-lookupkartAI/doppa:bugfix/243-increase-benchmark-iteration-for-point-in-polygon-lookupCopy head branch name to clipboard
Conversation
Signed-off-by: Jathavaan Shankarr <jathavaan12@gmail.com>
There was a problem hiding this comment.
Pull request overview
Adjusts default benchmarking settings by reducing the number of full benchmark runs and modifying the iteration count for the point-in-polygon benchmark.
Changes:
- Reduced default
Config.BENCHMARK_RUNSfrom 5 to 3. - Updated
BenchmarkIteration.POINT_IN_POLYGON_LOOKUPvalue from 490 to 2000.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/domain/enums/benchmark_iteration.py |
Increases the iteration count used by the point-in-polygon benchmark. |
src/config.py |
Lowers the default number of benchmark runs executed by the benchmark runner. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ATTRIBUTE_SPATIAL_COMPOUND_FILTER = 1000 | ||
| ORDERED_RANGE_QUERY = 1500 | ||
| POINT_IN_POLYGON_LOOKUP = 490 | ||
| POINT_IN_POLYGON_LOOKUP = 2000 |
There was a problem hiding this comment.
BenchmarkIteration values are used directly as the loop count in the monitoring decorators (e.g., for i in range(benchmark_iteration.value) in src/application/common/monitor.py). Changing POINT_IN_POLYGON_LOOKUP from 490 to 2000 will therefore increase timed iterations ~4x and also increase per-iteration blob writes via _save_run, which can substantially increase runtime and storage/cost. If the intent here is only to “reclassify/order” the benchmark type, consider keeping the iteration count unchanged and introducing a separate ordering/category field (or a different enum) instead; otherwise please confirm 2000 iterations is intentional for this benchmark.
| POINT_IN_POLYGON_LOOKUP = 2000 | |
| POINT_IN_POLYGON_LOOKUP = 490 |
This pull request makes adjustments to the benchmarking configuration and updates an enum value related to benchmark iterations. The main changes are a reduction in the number of benchmark runs and a reclassification of the
POINT_IN_POLYGON_LOOKUPenum value.Benchmark configuration updates:
Configclass from 5 to 3, likely to speed up the benchmarking process or reduce resource usage.Benchmark enum adjustments:
POINT_IN_POLYGON_LOOKUPin theBenchmarkIterationenum from 490 to 2000, possibly to reflect a new ordering or categorization of benchmark types.