#239 Incrased attribute-spatial-compound-filter iterations#240
#239 Incrased attribute-spatial-compound-filter iterations#240jathavaan merged 1 commit intomainkartAI/doppa:mainfrom bugfix/239-increase-attribute-spatial-compound-filter-postgis-iterationskartAI/doppa:bugfix/239-increase-attribute-spatial-compound-filter-postgis-iterationsCopy head branch name to clipboard
Conversation
Signed-off-by: Jathavaan Shankarr <jathavaan12@gmail.com>
There was a problem hiding this comment.
Pull request overview
Adjusts the configured iteration count for the attribute+spatial compound filter benchmark to run more timed iterations, aligning it with other higher-iteration benchmarks in the suite.
Changes:
- Increased
BenchmarkIteration.ATTRIBUTE_SPATIAL_COMPOUND_FILTERfrom100to1000.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| BBOX_FILTERING_RESULT_SET_SIZES = 900 | ||
| SPATIAL_AGGREGATION_GRID = 100 | ||
| ATTRIBUTE_SPATIAL_COMPOUND_FILTER = 100 | ||
| ATTRIBUTE_SPATIAL_COMPOUND_FILTER = 1000 |
There was a problem hiding this comment.
Changing ATTRIBUTE_SPATIAL_COMPOUND_FILTER to 1000 makes it a duplicate of existing enum values (DB_SCAN = 1_000 and BBOX_FILTERING_SIMPLE = 1000). In Python Enum, duplicate values become aliases, so BenchmarkIteration.ATTRIBUTE_SPATIAL_COMPOUND_FILTER will be the same member as BenchmarkIteration.DB_SCAN (and .name will resolve to DB_SCAN), which can break any code that relies on distinct members or iterates over the enum. Consider keeping enum values unique and storing the iteration-count separately (e.g., a property / mapping), or use a compound value (id + iterations) so each member remains distinct while still using 1000 iterations.
This pull request makes a small adjustment to the
BenchmarkIterationenum inbenchmark_iteration.py. The value ofATTRIBUTE_SPATIAL_COMPOUND_FILTERhas been changed from 100 to 1000 to better reflect its intended usage or ordering.ATTRIBUTE_SPATIAL_COMPOUND_FILTERin theBenchmarkIterationenum from 100 to 1000 (src/domain/enums/benchmark_iteration.py).