Release gridMap memory #62
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In planner.cpp, we allocate memory for binMap and never release it. This is then passed to voronoiDiagram.initializeMap() function, which assigns it to the gridMap member variable. In the subsequent calls to the function, we just assign this binMap or _gridMap parameter to the member variable gridMap, without releasing the existing gridMap memory. This results in memory leak.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In planner.cpp, we allocate memory for binMap and never release it. This is then passed to voronoiDiagram.initializeMap() function, which assigns it to the gridMap member variable.
In the subsequent calls to the function, we just assign this binMap or _gridMap parameter to the member variable gridMap, without releasing the existing gridMap memory. This results in memory leak.