fix: improve unresolved task deletion job #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems weird that the build failed on |
|
Yeah, probably a test-issue |
|
Anything I can do with this? |
kagkarlsson
reviewed
Apr 15, 2025
Comment on lines
+362
to
+369
| schedulerTaskRepository.getScheduledExecutions( | ||
| ScheduledExecutionsFilter.all(), | ||
| execution -> | ||
| taskToNewestExecutionTime.merge( | ||
| execution.taskInstance.getTaskName(), | ||
| execution.executionTime, | ||
| (oldValue, newValue) -> oldValue.isAfter(newValue) ? oldValue : newValue)); | ||
|
|
There was a problem hiding this comment.
I would rather avoid this...
Is there perhaps a way to have the TaskResolver also get information on how long the task-name has been unresolved 🤔 (and use that, rather than fetching all executions into mem and checking)
There was a problem hiding this comment.
I.e. do something here
For example, sending in the execution-time for the execution that is unresolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief, plain english overview of your changes here
Calculates age of unresolved execution based on it's execution time instead of first scheduler run.
More in issue: #515 (comment)
Fixes
#515
Reminders
mvn spotless:apply- also added.gitattributesbecause spotless went mad with CRLF on Windowscc @kagkarlsson