Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit ce4a8de

Browse filesBrowse files
committed
[FrameworkBundle] removed the session.default_locale parameter
1 parent f77b940 commit ce4a8de
Copy full SHA for ce4a8de

File tree

Expand file treeCollapse file tree

4 files changed

+6
-10
lines changed
Filter options
Expand file treeCollapse file tree

4 files changed

+6
-10
lines changed

‎src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,11 +143,11 @@ private function addSessionSection(ArrayNodeDefinition $rootNode)
143143
}
144144
return $v;
145145
})
146-
->end()
146+
->end()
147147
->children()
148148
->booleanNode('auto_start')->end()
149149
->scalarNode('class')->end()
150-
->scalarNode('default_locale')->end()
150+
->scalarNode('default_locale')->defaultValue('en')->end()
151151
->scalarNode('storage_id')->defaultValue('native')->end()
152152
// NativeSessionStorage options
153153
->scalarNode('name')->end()

‎src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
+1-3Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -295,9 +295,7 @@ private function registerSessionConfiguration(array $config, ContainerBuilder $c
295295
$container->setParameter('session.class', $config['class']);
296296
}
297297

298-
if (isset($config['default_locale'])) {
299-
$container->setParameter('session.default_locale', $config['default_locale']);
300-
}
298+
$container->getDefinition('session')->setArgument(1, $config['default_locale']);
301299

302300
$container->setAlias('session.storage', 'session.storage.'.$config['storage_id']);
303301

‎src/Symfony/Bundle/FrameworkBundle/Resources/config/session.xml

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Resources/config/session.xml
+1-4Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
<parameters>
88
<parameter key="session.class">Symfony\Component\HttpFoundation\Session</parameter>
9-
<parameter key="session.default_locale">en</parameter>
109
<parameter key="session.storage.native.class">Symfony\Component\HttpFoundation\SessionStorage\NativeSessionStorage</parameter>
1110
<parameter key="session.storage.native.options" type="collection" />
1211
<parameter key="session.storage.pdo.class">Symfony\Component\HttpFoundation\SessionStorage\PdoSessionStorage</parameter>
@@ -18,9 +17,7 @@
1817
<services>
1918
<service id="session" class="%session.class%">
2019
<argument type="service" id="session.storage" />
21-
<argument type="collection">
22-
<argument key="default_locale">%session.default_locale%</argument>
23-
</argument>
20+
<argument /> <!-- default locale -->
2421
</service>
2522

2623
<service id="session.storage.native" class="%session.storage.native.class%" public="false">

‎src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php

Copy file name to clipboardExpand all lines: src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php
+2-1Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,8 @@ public function testSession()
7272
$container = $this->createContainerFromFile('full');
7373

7474
$this->assertTrue($container->hasDefinition('session'), '->registerSessionConfiguration() loads session.xml');
75-
$this->assertEquals('fr', $container->getParameter('session.default_locale'));
75+
$arguments = $container->getDefinition('session')->getArguments();
76+
$this->assertEquals('fr', $arguments[1]);
7677
$this->assertTrue($container->getDefinition('session')->hasMethodCall('start'));
7778
$this->assertEquals('Session', $container->getParameter('session.class'));
7879
$this->assertEquals('session.storage.native', (string) $container->getAlias('session.storage'));

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.