analytical derivatives for noise functions #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Flo, Thanks a lot for the PR. I don't have time to do a review right now. But I'll try to get to it. It's a pretty cool feature after all. Do you have any additional notes or references on how you arrived at the analytic derivatives? It's been a while since I've worked on this as well and I'll probably struggle to review it without seeing it derived (no pun not intended :P) in smaller steps. Anyways really cool stuff. :) |
|
Sorry, missed that comment before, I'll try to write something up over the next days, as well as create a visual demo using that for "fake" erosion with fbm layers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to solve #57
Disclaimer: I heavily used AI to help me write this, my maths are not good enough otherwise ^^ I did write lots of tests though to check if stuff actually works and it all seems to work fine.
There is one small thing where I had to adjust the tests compared to the normal version though: in 3D and 4D comparing the analytical derivative to the finite difference derivative only works if we don't cross the boundary of our simplex shape, but I think that makes sense as the derivative is not continuous across the border (someone please correct me if I'm wrong). I adjusted the tests here to check a smaller area (and stay in one simplex shape).
Any feedback welcome, I would like to do some more (visual) testing in the coming days, which is why I opened this as a draft PR for now, so that I could get some feedback on the tests, etc I wrote already while doing that.