Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Jan 26, 2022. It is now read-only.

Restore debugger session state #75

Merged
merged 1 commit into from
Oct 21, 2019
Merged

Restore debugger session state #75

merged 1 commit into from
Oct 21, 2019

Conversation

JohanMabille
Copy link
Member

Fixes #52

jtpio
jtpio reviewed Oct 21, 2019
View reviewed changes
src/tokens.ts Show resolved Hide resolved
@jtpio
Copy link
Member

jtpio commented Oct 21, 2019

Thanks @JohanMabille!

There seems to be some errors when testing locally and reloading the page ( Cannot read property 'requestDebug' of null). They are most likely related to the kernel not being ready when sending the debug message (opened #76 for that so we can look at it later).

@jtpio jtpio merged commit cf0f168 into jupyterlab:master Oct 21, 2019
@jtpio jtpio mentioned this pull request Oct 21, 2019
Merged
@JohanMabille JohanMabille deleted the restore branch October 21, 2019 12:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jtpio jtpio jtpio approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Debugger state restoration

2 participants

@JohanMabille @jtpio
Morty Proxy This is a proxified and sanitized view of the page, visit original site.