Add ConsoleLauncher option to print discovery result #3164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3258b66 to
f5f0da3
Compare
|
How shell script friendly is this command? Can do something like: |
|
Dear @marcphilipp, Thank You very much for implementing this feature. It is amazing. I tried it a bit and found mismatches between the results of test discovery and test execution for the parameterized tests: 1 test after discovery and 4 tests after execution. It could be done by design. JDK: java -version
openjdk version "17.0.6" 2023-01-17 LTS
OpenJDK Runtime Environment Corretto-17.0.6.10.1 (build 17.0.6+10-LTS)
OpenJDK 64-Bit Server VM Corretto-17.0.6.10.1 (build 17.0.6+10-LTS, mixed mode, sharing)
Test code: import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.ValueSource;
class MavenExampleTest {
@Test
void shouldRun() {}
@ParameterizedTest
@ValueSource(strings = { "racecar", "radar", "able was I ere I saw elba" })
void palindromes(String candidate){}
}Test discovery: Test execution: |
That's to be expected. During the discovery phase only "static" tests can be detected. This means that you won't see dynamic test invocations or parameterized test invocations counted as tests during discovery, but you will see them during the execution phase. |
This commit adds a getter for TestPlan's 'allIdentifiers' field. Issue: #111
Executing 'java -jar junit.jar -cp "./test/" --list-tests' will return ╷ ├─ JUnit Vintage ↷ ├─ CarTest ↷ │ ├─ testModel() ↷ │ └─ testMake() ↷ └─ JUnit Jupiter ↷ Issue: #2854
The purpose of this interface is to be able to extend the 3 different details printing listeners which inherit TestExecutionListener: * TreePrintingListener * VerboseTreePrintingListener * FlatPrinting Listener Issue: #2854
When listing tests, the TreePrinter assumes the test is skipped and adds the '↷' symbol. If the test has no duration, result and reason, it is assumed the test is just being listed and the '↷' is omitted. Issue: #2854
All previous commits are connected and the feature is working. Issue: #2854
Pull request: #2870
Pull request: #2870
1b628f1 to
753c88f
Compare
180b92b to
46930ab
Compare
6 tasks
yhkuo41
pushed a commit
to yhkuo41/junit5
that referenced
this pull request
Apr 19, 2023
The new `--list-tests` option prints the result of test discovery. Resolves junit-team#2854. Co-authored-by: stoyanK7 <stoyank127@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotationsChange is documented in the User Guide and Release Noteswill be done in Introduce subcommands forConsoleLauncher#3243