Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Jan 23, 2026. It is now read-only.

Bump the default nginx ingress grpc timeouts#123

Merged
mangelajo merged 1 commit intomainjumpstarter-dev/jumpstarter-controller:mainfrom
grpc-timeouts-ingressjumpstarter-dev/jumpstarter-controller:grpc-timeouts-ingressCopy head branch name to clipboard
Mar 21, 2025
Merged

Bump the default nginx ingress grpc timeouts#123
mangelajo merged 1 commit intomainjumpstarter-dev/jumpstarter-controller:mainfrom
grpc-timeouts-ingressjumpstarter-dev/jumpstarter-controller:grpc-timeouts-ingressCopy head branch name to clipboard

Conversation

@mangelajo
Copy link
Member

@mangelajo mangelajo commented Mar 21, 2025 •
edited by coderabbitai bot
Loading

Raise the timeouts to lower the chances of timeout disconnection for our grpc streams.

Summary by CodeRabbit

  • New Features
    • Enhanced network gateway configurations by updating timeout settings. These adjustments extend the duration for waiting on responses and sending data, which improves system reliability and performance during backend interactions.

@mangelajo
Bump the default nginx ingress grpc timeouts
9b00977 
Raise the timeouts to lower the chances of timeout disconnection
for our grpc streams.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 21, 2025 •
edited
Loading

Walkthrough

This pull request updates two Ingress configuration files by adding two new annotations that set the proxy read and send timeouts to 300 seconds. The modifications apply to the corresponding YAML files without altering any public or exported entities.

Changes

File(s) Change Summary
deploy/helm/.../templates/controller-ingress.yaml
deploy/helm/.../templates/router-ingress.yaml		 Added nginx.ingress.kubernetes.io/proxy-read-timeout: "300" and nginx.ingress.kubernetes.io/proxy-send-timeout: "300" annotations.

Suggested reviewers

  • bennyz

Poem

In fields of code, I softly roam,
Hop by hop, I find a new home.
YAML lines now sing in rhyme,
With timeouts set to keep in time.
A joyful PR from a rabbit—pure and sublime!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 73628b2 and 9b00977.

📒 Files selected for processing (2)
  • deploy/helm/jumpstarter/charts/jumpstarter-controller/templates/controller-ingress.yaml (1 hunks)
  • deploy/helm/jumpstarter/charts/jumpstarter-controller/templates/router-ingress.yaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: e2e-tests (ubuntu-24.04)
  • GitHub Check: e2e-tests-28d6b1cc3b49ab9ae176918ab9709a2e2522c97e
  • GitHub Check: e2e-tests (ubuntu-24.04-arm)
🔇 Additional comments (2)
deploy/helm/jumpstarter/charts/jumpstarter-controller/templates/router-ingress.yaml (1)

8-9: New gRPC Timeout Annotations Added

The new annotations
nginx.ingress.kubernetes.io/proxy-read-timeout: "300" and
nginx.ingress.kubernetes.io/proxy-send-timeout: "300"
satisfy the PR objective by increasing the gRPC timeout settings to 300 seconds. The values are clearly set and the templating syntax remains intact. Please verify that these timeout values align with the expected behavior of your service and are sufficient for handling long-lived gRPC streams.

deploy/helm/jumpstarter/charts/jumpstarter-controller/templates/controller-ingress.yaml (1)

8-9: Consistent Timeout Settings for Controller Ingress

The addition of
nginx.ingress.kubernetes.io/proxy-read-timeout: "300" and
nginx.ingress.kubernetes.io/proxy-send-timeout: "300"
ensures that the controller ingress configuration now matches the updated timeout requirements. This consistency across both router and controller configurations is key for uniform behavior across your gRPC streams. Confirm that these settings integrate well with your overall ingress strategy.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@mangelajo mangelajo merged commit 13485df into main Mar 21, 2025
8 checks passed
@mangelajo mangelajo added this to the 0.6.0 milestone May 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bennyz bennyz bennyz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.6.0

Development

Successfully merging this pull request may close these issues.

2 participants

@mangelajo @bennyz
Morty Proxy This is a proxified and sanitized view of the page, visit original site.