Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 29b5357

Browse filesBrowse files
authored
Merge pull request hub4j#358 from jglick/no-preview-JENKINS-36240
[JENKINS-36240] /repos/:owner/:repo/collaborators/:username/permission no longer requires korra preview
2 parents f2fe8ea + 3a40af8 commit 29b5357
Copy full SHA for 29b5357

File tree

Expand file treeCollapse file tree

2 files changed

+1
-4
lines changed
Filter options
Expand file treeCollapse file tree

2 files changed

+1
-4
lines changed

‎src/main/java/org/kohsuke/github/GHRepository.java

Copy file name to clipboardExpand all lines: src/main/java/org/kohsuke/github/GHRepository.java
+1-3Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -486,9 +486,8 @@ public Set<String> getCollaboratorNames() throws IOException {
486486
* @throws FileNotFoundException under some conditions (e.g., private repo you can see but are not an admin of); treat as unknown
487487
* @throws HttpException with a 403 under other conditions (e.g., public repo you have no special rights to); treat as unknown
488488
*/
489-
@Deprecated @Preview
490489
public GHPermissionType getPermission(String user) throws IOException {
491-
GHPermission perm = root.retrieve().withPreview(KORRA).to(getApiTailUrl("collaborators/" + user + "/permission"), GHPermission.class);
490+
GHPermission perm = root.retrieve().to(getApiTailUrl("collaborators/" + user + "/permission"), GHPermission.class);
492491
perm.wrapUp(root);
493492
return perm.getPermissionType();
494493
}
@@ -498,7 +497,6 @@ public GHPermissionType getPermission(String user) throws IOException {
498497
* @throws FileNotFoundException under some conditions (e.g., private repo you can see but are not an admin of); treat as unknown
499498
* @throws HttpException with a 403 under other conditions (e.g., public repo you have no special rights to); treat as unknown
500499
*/
501-
@Deprecated @Preview
502500
public GHPermissionType getPermission(GHUser u) throws IOException {
503501
return getPermission(u.getLogin());
504502
}

‎src/main/java/org/kohsuke/github/Previews.java

Copy file name to clipboardExpand all lines: src/main/java/org/kohsuke/github/Previews.java
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,4 @@
77
static final String LOKI = "application/vnd.github.loki-preview+json";
88
static final String DRAX = "application/vnd.github.drax-preview+json";
99
static final String SQUIRREL_GIRL = "application/vnd.github.squirrel-girl-preview";
10-
static final String KORRA = "application/vnd.github.korra-preview";
1110
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.