Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Build docs with JDK 24. #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cpovirk merged 1 commit into from
Apr 4, 2025
Merged

Build docs with JDK 24. #737

cpovirk merged 1 commit into from
Apr 4, 2025

Conversation

@cpovirk
Copy link
Collaborator

@cpovirk cpovirk commented Apr 4, 2025

No description provided.

@cpovirk cpovirk requested a review from netdpb April 4, 2025 17:06
@cpovirk
Copy link
Collaborator Author

cpovirk commented Apr 4, 2025

I assume that the build failure is unrelated. But as is often the case, I can't figure out whether there's a way to force retesting, aside from maybe force-pushing an identical commit?

@cpovirk
Copy link
Collaborator Author

cpovirk commented Apr 4, 2025

OK, now that all the checks completed, I see the "Re-run all jobs" / "Re-run failed jobs" button. So I'm now able to kick off a new run.

@cpovirk cpovirk merged commit 9470cd3 into main Apr 4, 2025
10 of 13 checks passed
@cpovirk cpovirk deleted the doc24 branch April 4, 2025 21:39
@cpovirk
Copy link
Collaborator Author

cpovirk commented Apr 4, 2025

Post-merge, I see this failure:

> Task :npmInstall
npm WARN deprecated rimraf@3.0.2: Rimraf versions prior to v4 are no longer supported
npm WARN deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm WARN deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm ERR! code ECONNRESET
npm ERR! network aborted
npm ERR! network This is a problem related to network connectivity.
npm ERR! network In most cases you are behind a proxy or have bad network settings.
npm ERR! network 
npm ERR! network If you are behind a proxy, please make sure that the
npm ERR! network 'proxy' config is set properly.  See: 'npm help config'

I'm hoping that it, too, is flakiness. I'll re-run it.

@cpovirk
Copy link
Collaborator Author

cpovirk commented Apr 4, 2025

Yep, better on the second try.

cpovirk added a commit that referenced this pull request Oct 2, 2025
@cpovirk
Build docs with JDK 25.
963a03a 
Compare #737.

This came up in
#484 (comment).

I notice that JDK 25 fixes https://bugs.openjdk.org/browse/JDK-8345664,
but that's probably not relevant to JSpecify.
@cpovirk cpovirk mentioned this pull request Oct 2, 2025
Merged
cpovirk added a commit that referenced this pull request Oct 2, 2025
@cpovirk
Build docs with JDK 25. (#774)
0581574 
Compare #737.

This came up in
#484 (comment).

I notice that JDK 25 fixes https://bugs.openjdk.org/browse/JDK-8345664,
but that's probably not relevant to JSpecify.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@netdpb netdpb netdpb approved these changes

Assignees

@netdpb netdpb

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cpovirk @netdpb
Morty Proxy This is a proxified and sanitized view of the page, visit original site.