Adding encoding as parameter to methods deserialize and serialize#253
Open
leocampos wants to merge 1 commit intojson-iterator:masterjson-iterator/java:masterfrom
Open
Adding encoding as parameter to methods deserialize and serialize#253leocampos wants to merge 1 commit intojson-iterator:masterjson-iterator/java:masterfrom
leocampos wants to merge 1 commit intojson-iterator:masterjson-iterator/java:masterfrom
Conversation
…JsonStream.serialize
|
@taowen is there any chance this could get merged? it's fixing a pretty big issue |
Author
|
BTW, we are mostly starting to migrate to another JSON parser in which the development is more active. |
|
@leocampos what's the name of the new JSON parser that you mentioned the development is active |
Author
|
@pradeepcheers We are currently using Jackson. The approach we took, though, was to wrap it around a class of ours, so we can later choose the library and change it in a single place. |
|
For UTF-16 this PR crashes with: com.jsoniter.spi.JsonException: read: premature end, head: 1, peek: �, buf: �� { " n a m e " : " T h o m a s M � l l e r " }
at com.jsoniter/com.jsoniter.JsonIterator.reportError(JsonIterator.java:143)
at com.jsoniter/com.jsoniter.JsonIterator.readAny(JsonIterator.java:272)
at com.jsoniter/com.jsoniter.JsonIterator.deserialize(JsonIterator.java:522)
at com.jsoniter/com.jsoniter.JsonIterator.deserialize(JsonIterator.java:505)
at com.jsoniter/com.jsoniter.TestString.test_encoding_different_than_default(TestString.java:41)Also the test does not work for Java 17 modules as reflective access to Charset.defaultCharset is prohibited. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request tries to address the issue #229
Especially with so many managed services on the Cloud, some of which we do not have any control over the initialization of the JVM, it is important to be able to control the encoding used by the library. I faced recently the problem of having one of these managed services in US-ASCII, but our Strings were encoded with UTF-8. All special characters were transformed to "?".