Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Revert "Possible fix for #168 - Always create new instance of col"#171

Merged
taowen merged 1 commit intojson-iterator:masterjson-iterator/java:masterfrom
elifarley:revert-169-patch-1elifarley/java:revert-169-patch-1Copy head branch name to clipboard
Mar 6, 2018
Merged

Revert "Possible fix for #168 - Always create new instance of col"#171
taowen merged 1 commit intojson-iterator:masterjson-iterator/java:masterfrom
elifarley:revert-169-patch-1elifarley/java:revert-169-patch-1Copy head branch name to clipboard

Conversation

@elifarley
Copy link
Contributor

@elifarley elifarley commented Mar 5, 2018

Reverts #169

Failed tests: 
com.jsoniter.TestExisting.test_reuse_linked_list(com.jsoniter.TestExisting)
  Run 1: TestExisting.test_reuse_linked_list:61 expected:<1753447031> but was:<1810132623>
  Run 2: PASS
  Run 3: PASS
  Run 4: TestExisting.test_reuse_linked_list:61 expected:<764577347> but was:<1344645519>
com.jsoniter.TestExisting.test_reuse_list(com.jsoniter.TestExisting)
  Run 1: TestExisting.test_reuse_list:54 expected:<745160567> but was:<610984013>
  Run 2: PASS
  Run 3: PASS
  Run 4: TestExisting.test_reuse_list:54 expected:<1458540918> but was:<1164371389>

This change is Reviewable

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@42a3e08). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #171   +/-   ##
=========================================
  Coverage          ?   68.04%           
=========================================
  Files             ?      107           
  Lines             ?     7301           
  Branches          ?     1379           
=========================================
  Hits              ?     4968           
  Misses            ?     1881           
  Partials          ?      452
Impacted Files Coverage Δ
...java/com/jsoniter/ReflectionCollectionDecoder.java 61.9% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42a3e08...24a8d36. Read the comment docs.

@taowen taowen merged commit c1ef60a into json-iterator:master Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.