#99 added mustBeValid method to Any class#100
Merged
taowen merged 1 commit intojson-iterator:masterjson-iterator/java:masterfrom Sep 12, 2017
Merged
#99 added mustBeValid method to Any class#100taowen merged 1 commit intojson-iterator:masterjson-iterator/java:masterfrom
taowen merged 1 commit intojson-iterator:masterjson-iterator/java:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
==========================================
+ Coverage 67.59% 71.74% +4.14%
==========================================
Files 90 90
Lines 6404 6409 +5
Branches 1225 1230 +5
==========================================
+ Hits 4329 4598 +269
+ Misses 1660 1405 -255
+ Partials 415 406 -9
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the "mustBeValid" and "test_not_found" methods.
I had to change the JsonException exception field of NotFoundAny from private to protected, so that I could access the exact reason of value being not found.
When I run the tests I have 12 failed - even if I clone your repo and run the tests without any changes - I can't tell if there is a problem with the code I introduced. Sorry for the inconvenience.