Broaden closure to method coercion with included blocks #8949
+36
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows define_method to be converted to a method with nested blocks so long as those nested blocks do not get captures from outside define_method. As it stands this hurts performance: https://gist.github.com/enebo/7256fd51d3f0ebb49d433f2bc3e77d02 It appears that something is not optimizing correctly for these converted blocks. `nested capture def` should be the performance for `nested capture` and for sure should be faster than just invoking `nested capture` with the optimization disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows define_method to be converted to a method with nested blocks so long as those nested blocks do not get captures from outside define_method.
As it stands this hurts performance:
https://gist.github.com/enebo/7256fd51d3f0ebb49d433f2bc3e77d02
It appears that something is not optimizing correctly for these converted blocks.
nested capture defshould be the performance fornested captureand for sure should be faster than just invokingnested capturewith the optimization disabled.