Fix #855 Modal overlay forces a horizontal scrollbar in IE 9 #915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ls#561 Scrollable circular loop shows blank areas, should be seamless
…% for left and top and margins in pixels (so now it stays centered on window resize). For "absolute" positioning it uses the old positioning in pixels.
…ix for jquerytools#87 - fixes initial position not only for circular scrollable with initialIndex = 0, but for non circular scrollable and any initialIndex too.
|
Hi vlazar, Thanks for this - any chance you could please separate out these commits into separate instances? It will help - if one has an issue, then we would otherwise have to pull the whole lot. It would also help if you could please provide a JSfiddle showing the test case, and how your fixes help if possible? |
|
Hi alibby251, Sure, will do this as soon as I have time. Any interest in other commits, not related to #855 BTW? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue described here #855
The removed
window.innerWidthreturns window width, but it also includes vertical scrollbar width (if present). And it is for ie9+ only, but the comment incorrectly says it's for ie7+.I've checked
document.documentElement.clientWidthand it gives correct results in ie7, ie8, ie9.The jQuery's
$(window).width()also returns correct width, and can also be used, but I wanted the fix to be minimal.